Merge pull request #39 from primer/release-8.0.0

chore: v8.0.0

.github/workflows/ci.yml

@@ -0,0 +1,20 @@
+name: CI
+on: [push]
+jobs:
+  all:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@master
+      - uses: actions/setup-node@master
+        with:
+          version: 11
+      - name: install
+        run: npm install
+      - name: lint
+        run: npm run lint
+      - name: test
+        run: npm test
+      - uses: primer/[email protected]
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NPM_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}

.npmrc

@@ -1,3 +1 @@
-save=true
-save-exact=true
 git-tag-version=false

README.md

@@ -26,7 +26,7 @@ Within your [stylelint config object](http://stylelint.io/user-guide/configurati
 
 * [stylelint-scss](https://github.com/kristerkari/stylelint-scss): A collection of SCSS specific linting rules for stylelint
   * [scss/selector-no-redundant-nesting-selector](https://github.com/kristerkari/stylelint-scss/blob/master/src/rules/selector-no-redundant-nesting-selector/README.md): Disallow redundant nesting selectors (`&`).
-* [stylelint-selector-no-utility](https://github.com/primer/stylelint-selector-no-utility): Stylelint rule that doesn't allow the styling of utility classes in CSS
+* [primer/no-override](plugins/no-override.js): Prohibits custom styles that target Primer CSS selectors.
 
 ### Configured lints
 

__tests__/index.js

@@ -1,4 +1,4 @@
-const {lint, extendDefaultConfig} = require('./utils')
+const {lint} = require('./utils')
 
 const SAFE_SCSS_EXAMPLE = `
   .Component { color: $gray-500; }
@@ -47,25 +47,4 @@ describe('stylelint-config-primer', () => {
       expect(data).toHaveDeprecationsLength(0)
     })
   })
-
-  it('warns about the planned deprecation of primer/selector-no-utility', () => {
-    return lint(
-      SAFE_SCSS_EXAMPLE,
-      extendDefaultConfig({
-        rules: {
-          'primer/selector-no-utility': true
-        }
-      })
-    ).then(data => {
-      expect(data).not.toHaveErrored()
-      expect(data).not.toHaveResultsLength(0)
-      expect(data).toHaveDeprecationsLength(1)
-      expect(data.results[0].deprecations).toEqual([
-        {
-          text: `'primer/selector-no-utility' has been deprecated and will be removed in [email protected]. Please update your rules to use 'primer/no-override'.`,
-          reference: 'https://github.com/primer/stylelint-config-primer#deprecations'
-        }
-      ])
-    })
-  })
 })

__tests__/no-override.js

@@ -5,7 +5,7 @@ describe('primer/no-override', () => {
     return lint('.text-gray { color: #111; }').then(data => {
       expect(data).toHaveErrored()
       expect(data).toHaveWarningsLength(1)
-      expect(data).toHaveWarnings([`The selector ".text-gray" should not be overridden. (primer/no-override)`])
+      expect(data).toHaveWarnings([`".text-gray" should not be overridden (found in utilities). (primer/no-override)`])
     })
   })
 
@@ -14,7 +14,7 @@ describe('primer/no-override', () => {
     return lint(`${selector} { color: #f00; }`).then(data => {
       expect(data).toHaveErrored()
       expect(data).toHaveWarningsLength(1)
-      expect(data).toHaveWarnings([`The selector "${selector}" should not be overridden. (primer/no-override)`])
+      expect(data).toHaveWarnings([`"${selector}" should not be overridden (found in utilities). (primer/no-override)`])
     })
   })
 
@@ -23,7 +23,9 @@ describe('primer/no-override', () => {
     return lint(`.foo ${selector}:focus { color: #f00; }`).then(data => {
       expect(data).toHaveErrored()
       expect(data).toHaveWarningsLength(1)
-      expect(data).toHaveWarnings([`The selector "${selector}" should not be overridden. (primer/no-override)`])
+      expect(data).toHaveWarnings([
+        `"${selector}" should not be overridden in ".foo ${selector}:focus" (found in utilities). (primer/no-override)`
+      ])
     })
   })
 

index.js

@@ -2,13 +2,7 @@ const browsers = require('./browsers')
 const propertyOrder = require('./property-order')
 
 module.exports = {
-  plugins: [
-    'stylelint-no-unsupported-browser-features',
-    'stylelint-order',
-    'stylelint-scss',
-    './plugins/no-override',
-    './plugins/selector-no-utility'
-  ],
+  plugins: ['stylelint-no-unsupported-browser-features', 'stylelint-order', 'stylelint-scss', './plugins/no-override'],
   rules: {
     'at-rule-blacklist': ['extend'],
     'at-rule-name-case': 'lower',