Revert "feat(TextInput): Update TextInput to use data attributes for …

…styling …" (#5256) This reverts commit 706d272.
primer · Nov 8, 2024 · c424c36 · c424c36
1 parent 64802f1
commit c424c36
Show file tree

Hide file tree

Showing 8 changed files with 2,784 additions and 9,273 deletions.
diff --git a/.changeset/real-fans-tap.md b/.changeset/real-fans-tap.md
diff --git a/packages/react/src/TextInputWithTokens/TextInputWithTokens.tsx b/packages/react/src/TextInputWithTokens/TextInputWithTokens.tsx
@@ -13,7 +13,7 @@ import Token from '../Token/Token'
 import type {TokenSizeKeys} from '../Token/TokenBase'
 
 import type {TextInputSizes} from '../internal/components/TextInputWrapper'
-import TextInputWrapper from '../internal/components/TextInputWrapper'
+import TextInputWrapper, {textInputHorizPadding} from '../internal/components/TextInputWrapper'
 import UnstyledTextInput from '../internal/components/UnstyledTextInput'
 import TextInputInnerVisualSlot from '../internal/components/TextInputInnerVisualSlot'
 
@@ -266,8 +266,8 @@ function TextInputWithTokensInnerComponent<TokenComponentType extends AnyReactCo
       variant={variantProp} // deprecated. use `size` prop instead
       onClick={focusInput}
       sx={{
-        paddingLeft: '12px',
-        py: `calc(12px / 2)`,
+        paddingLeft: textInputHorizPadding,
+        py: `calc(${textInputHorizPadding} / 2)`,
         ...(block
           ? {
               display: 'flex',

diff --git a/packages/react/src/__tests__/Textarea.test.tsx b/packages/react/src/__tests__/Textarea.test.tsx
@@ -84,11 +84,11 @@ describe('Textarea', () => {
       width: '100%',
       display: 'flex',
     }
-    const defaultStyles = renderStyles(<Textarea />)
-    const blockStyles = renderStyles(<Textarea block />)
+    const defaultStyles = renderStyles(<Textarea block />)
+    const blockStyles = renderStyles(<Textarea />)
 
-    expect(defaultStyles).not.toEqual(expect.objectContaining(expectedStyles))
-    expect(blockStyles).toEqual(expect.objectContaining(expectedStyles))
+    expect(defaultStyles).toEqual(expect.objectContaining(expectedStyles))
+    expect(blockStyles).not.toEqual(expect.objectContaining(expectedStyles))
   })
 
   it('renders default resize values correctly', () => {