Damovisa/dark high contrast inline code block #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b7991c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Colors changed--- base/themes/dark-colorblind.json 2024-10-03 02:06:44.674164603 +0000
+++ themes/dark-colorblind.json 2024-10-03 02:06:42.670144381 +0000
@@ -13,2 +13,3 @@
"textPreformat.foreground": "#8b949e",
+ "textPreformat.background": "#6e768166",
"textSeparator.foreground": "#21262d",
--- base/themes/dark-default.json 2024-10-03 02:06:44.674164603 +0000
+++ themes/dark-default.json 2024-10-03 02:06:42.670144381 +0000
@@ -13,2 +13,3 @@
"textPreformat.foreground": "#7d8590",
+ "textPreformat.background": "#6e768166",
"textSeparator.foreground": "#21262d",
--- base/themes/dark-dimmed.json 2024-10-03 02:06:44.674164603 +0000
+++ themes/dark-dimmed.json 2024-10-03 02:06:42.670144381 +0000
@@ -13,2 +13,3 @@
"textPreformat.foreground": "#768390",
+ "textPreformat.background": "#636e7b66",
"textSeparator.foreground": "#373e47",
--- base/themes/dark-high-contrast.json 2024-10-03 02:06:44.674164603 +0000
+++ themes/dark-high-contrast.json 2024-10-03 02:06:42.670144381 +0000
@@ -13,2 +13,3 @@
"textPreformat.foreground": "#f0f3f6",
+ "textPreformat.background": "#9ea7b366",
"textSeparator.foreground": "#7a828e",
--- base/themes/light-colorblind.json 2024-10-03 02:06:44.674164603 +0000
+++ themes/light-colorblind.json 2024-10-03 02:06:42.669144375 +0000
@@ -13,2 +13,3 @@
"textPreformat.foreground": "#57606a",
+ "textPreformat.background": "#afb8c133",
"textSeparator.foreground": "#d8dee4",
--- base/themes/light-default.json 2024-10-03 02:06:44.674164603 +0000
+++ themes/light-default.json 2024-10-03 02:06:42.669144375 +0000
@@ -13,2 +13,3 @@
"textPreformat.foreground": "#656d76",
+ "textPreformat.background": "#afb8c133",
"textSeparator.foreground": "#d8dee4",
--- base/themes/light-high-contrast.json 2024-10-03 02:06:44.674164603 +0000
+++ themes/light-high-contrast.json 2024-10-03 02:06:42.669144375 +0000
@@ -13,2 +13,3 @@
"textPreformat.foreground": "#0e1116",
+ "textPreformat.background": "#acb6c033",
"textSeparator.foreground": "#88929d", |
simurai
approved these changes
Oct 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here.
Inline highlighted text in the Copilot Chat response was unreadable in the GitHub Dark High Contrast theme. This PR adds a missing background color for the
textPreformat.backgroundvariable.Closes #380
Screenshots
Before:
After:
Merge checklist
GitHub Light DefaultthemeTake a look at the Contribute section for more information on how test your changes locally.