Fixing cssTransitionfalse does not disable animations globally #7417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
When submitting a PR, please also create an issue documenting the error and manually link to an issue or mention it in the description using #<issue_id>.
Fix #7395
Description -
Problem is in file
PrimeReactContext.js
, line 15const [cssTransition, setCssTransition] = useState(propsValue.cssTransition || true);
|| is OR, which basically means that even when cssTransition from props is
false
,false || true
returntrue
.Instead of OR what we really want is 'Nullish coalescing operator (??)', which returns its right-hand side operand when its left-hand side operand is null or undefined, and otherwise returns its left-hand side.
Updating the same for other props as well.