Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6522: Minus sign after all selection - InputNumber #6566

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix #6522: Minus sign after all selection - InputNumber #6566

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
181f3d0
Fix #6522: Minus sign after all selection - InputNumber
May 4, 2024
b3089bb
Formatted
ujshaikh May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions components/lib/inputnumber/InputNumber.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ export const InputNumber = React.memo(
}

_currency.current.lastIndex = 0;

return { decimalCharIndex, minusCharIndex, suffixCharIndex, currencyCharIndex };
};

Expand All @@ -672,7 +672,8 @@ export const InputNumber = React.memo(
if (sign.isMinusSign) {
const isNewMinusSign = minusCharIndex === -1;

if (isNewMinusSign && (selectionStart === 0 || selectionStart === currencyCharIndex + 1)) {
// #6522 - Selected negative value can't be overwritten with a minus ('-') symbol
if (selectionStart === 0 || selectionStart === currencyCharIndex + 1) {
newValueStr = inputValue;

if (isNewMinusSign || selectionEnd !== 0) {
Expand Down