Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5188: Generates the primereact.css so it can prevent FOUC #5228

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix #5188: Generates the primereact.css so it can prevent FOUC #5228

wants to merge 5 commits into from

Conversation

melloware
Copy link
Member

@melloware melloware commented Nov 2, 2023 •
edited

Fix #5188: Generates the primereact.css so it can prevent FOUC

  • Wrap everything in 1 layer to reduce size
  • Add global styles
  • Move keyframes inside @layer and verified everything works

@melloware melloware added the Core Team Issue or pull request has been *opened* by a member of Core Team label Nov 2, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 2, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 0:27am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 0:27am

@gestion-procesos
Copy link

any update here?

@melloware
Copy link
Member Author

Just waiting for PrimeTek to review.

@nitrogenous
Copy link
Member

Will discuss this week for next release

@mertsincan
Copy link
Member

We need to do something like ServerStyleSheet. Exp;
https://medium.com/swlh/server-side-rendering-styled-components-with-nextjs-1db1353e915e

@mertsincan mertsincan added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertsincan mertsincan Awaiting requested review from mertsincan

@nitrogenous nitrogenous Awaiting requested review from nitrogenous

@gucal gucal Awaiting requested review from gucal

Assignees

@mertsincan mertsincan

Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Status: Discussion Issue or pull request needs to be discussed by Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flash of unstyled content (FOUC)
4 participants
@melloware @gestion-procesos @nitrogenous @mertsincan