Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds desktop system tag to desktop systems. #2254

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Sep 21, 2024

This can be useful to use to filter desktop systems, such as os.istarget("desktop").

@tritao
Copy link
Contributor Author

tritao commented Sep 21, 2024

I left uwp alone as its universal, should it be tagged as both desktop and mobile?

Copy link
Contributor

@Jarod42 Jarod42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad that the whole documentation is obsolete/missing for that part:

  • os.istarget is missing
  • os.is is deprecated and redirect to os.target...

@tritao
Copy link
Contributor Author

tritao commented Sep 21, 2024

Sad that the whole documentation is obsolete/missing for that part:

  • os.istarget is missing
  • os.is is deprecated and redirect to os.target...

Ok, I can add those missing docs and include the concept of tags too.

@tritao
Copy link
Contributor Author

tritao commented Sep 21, 2024

Updated the PR with some docs.

@tritao tritao marked this pull request as ready for review September 21, 2024 12:50
website/docs/os.istarget.md Show resolved Hide resolved
website/docs/os.getSystemTags.md Show resolved Hide resolved
website/docs/os.getSystemTags.md Outdated Show resolved Hide resolved
@tritao
Copy link
Contributor Author

tritao commented Sep 25, 2024

Updated PR with review suggestions.

Also found meanwhile https://github.com/Blizzard/premake-blizzard/blob/master/blizzard.lua#L25, so it shows some prior art as this being useful to someone else at least.

@samsinsane
Copy link
Member

I left uwp alone as its universal, should it be tagged as both desktop and mobile?

I guess it depends on what "mobile" means? Do we factor in Windows Phone despite it being unsupported by Microsoft for years already? I don't think we should.

Does tagging with both create problems with usage? Using both filter { "system:mobile" } and filter { "system:desktop" } would create problems with systems tagged as both. While you could do filter { "system:mobile", "system:not desktop" } that becomes unreasonable if you include console which UWP could also be tagged with, or a tag for AR/VR/XR which UWP could also be tagged with.

Personally, I think uwp being tagged with desktop is fine, but others may disagree.

@tritao
Copy link
Contributor Author

tritao commented Sep 26, 2024

I guess it depends on what "mobile" means? Do we factor in Windows Phone despite it being unsupported by Microsoft for years already? I don't think we should.

Personally, I think uwp being tagged with desktop is fine, but others may disagree.

Ok, this sounds reasonable to me, I have updated the PR with that suggestion.

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues, but otherwise looks good.

website/docs/os.getSystemTags.md Outdated Show resolved Hide resolved
website/docs/os.getSystemTags.md Outdated Show resolved Hide resolved
website/docs/os.istarget.md Outdated Show resolved Hide resolved
website/docs/os.istarget.md Outdated Show resolved Hide resolved
@tritao
Copy link
Contributor Author

tritao commented Sep 26, 2024

Thanks for the review, all should be fixed now, and updated the docs with a table reference for the tags.

This can be useful to use to filter desktop systems, such as
`os.istarget("desktop")`.
@samsinsane samsinsane merged commit ac4ef40 into premake:master Sep 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants