Fix stack manipulation in Premake's luaL_loadfilex override.
#2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
force-pushed
the
fix-stack-manip-loadfilex
branch
2 times, most recently
from
78690c2
to
3914c21
Compare
Jarod42
reviewed
Sep 5, 2024
tritao
force-pushed
the
fix-stack-manip-loadfilex
branch
from
3914c21
to
b92c0c8
Compare
Jarod42
reviewed
Sep 6, 2024
Jarod42
approved these changes
Sep 6, 2024
An example of code that did not work:
```lua
local env = { ["foo"] = function(n) print(n) end }
assert(pcall(loadfile("foo.lua", nil, env))
```
tritao
force-pushed
the
fix-stack-manip-loadfilex
branch
from
b92c0c8
to
afcbbb2
Compare
|
Updated with a new test without a custom env, as requested. |
Jarod42
approved these changes
Sep 17, 2024
samsinsane
approved these changes
Sep 24, 2024
noresources
added a commit
to depinxi/premake-core
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows the Lua base functionality of passing a custom environment to
loadfileto work.I believe this has been broken for like 7 or more years, since the upgrade to Lua 5.2.
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!