Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nitrogen #92

Open
wants to merge 52 commits into
base: develop
Choose a base branch
from
Open

Nitrogen #92

wants to merge 52 commits into from

Conversation

miladagreen
Copy link

@miladagreen miladagreen commented Feb 27, 2024

  • ✅ added nitrogen map
  • ✅ upgraded bit map
  • ✅ added required note on necessary inputs
  • ✅ growth stage added
  • ✅ *** NEEDS UPDATED BUILD WORKFLOW ***

@mikahpinegar
Copy link
Contributor

build is failing due to dockerfile not being updated

Copy link

Your review app has been deployed and is available at 'http://172.214.61.236:80'.

Learn More about how to test and provide feedback for the app.

@mikahpinegar
Copy link
Contributor

changing the cover crop species doesn't update it in the summary widget

@mikahpinegar
Copy link
Contributor

changing termination date doesn't update the summary widget

@mikahpinegar
Copy link
Contributor

changing species or growth stage doesn't update carbohydrates, holo-cellulose, or lignin in the summary widget

@mikahpinegar
Copy link
Contributor

also, after thinking about it more loading in an example definitely shouldn't auto fill the biomass and nitrogen values. as the api is updated, it may change the output. we only want the example to load in the geometry but always use the api to get the biomass and nitrogen

@mikahpinegar
Copy link
Contributor

loading in an example after already defining a geometry should clear the old geometry

@rickhitchcock
Copy link
Collaborator

rickhitchcock commented Apr 29, 2024

The User Sampled branch needs a cash crop planting date (found on the Cash Crop tab), and a cover crop termination date (found on the Cover Crop tab). Note that these dates should not have default values.

The program has unspecified planting and termination dates on the Location tab. I think these can go away.

The planting date on the Location tab is actually the cover crop planting date, which isn't needed for the User Sampled branch. (I'm also unsure why it's needed in the Satellite branch, but I need to study that some more.)

@rickhitchcock
Copy link
Collaborator

The User Sampled branch creates a biomass map if a polygon is created. I don't think this should happen – unless someone requested that feature(?)

@rickhitchcock
Copy link
Collaborator

rickhitchcock commented Apr 29, 2024

On the About screen, a space is needed after "visit":
visithttps://precisionsustainableag.org/.

@rickhitchcock
Copy link
Collaborator

After choosing User Sampled and Example: Grass, the program crashes if you click Cover Crop.

@rickhitchcock
Copy link
Collaborator

rickhitchcock commented Apr 29, 2024

For the User Sampled path, Biomass Map and Nitrogen Map should not be on the menu on the Output screen.

@rickhitchcock
Copy link
Collaborator

Now that About appears on the Home screen, I don't think it's needed in the drop-down.

@rickhitchcock
Copy link
Collaborator

rickhitchcock commented Apr 29, 2024

This may be a question for the group, but I think that Feedback should always be visible rather than on the drop-down. (This is the case for the original program, the Selector, Vegspec, and CC-Econ).

Also, Feedback should be sent to the Feedback API rather than to dst-ncalc/discussions.

Copy link

Your review app has been deployed and is available at 'http://172.214.61.236:80'.

Learn More about how to test and provide feedback for the app.

1 similar comment
Copy link

Your review app has been deployed and is available at 'http://172.214.61.236:80'.

Learn More about how to test and provide feedback for the app.

Copy link

Your review app has been deployed and is available at 'http://172.214.61.236:80'.

Learn More about how to test and provide feedback for the app.

1 similar comment
Copy link

Your review app has been deployed and is available at 'http://172.214.61.236:80'.

Learn More about how to test and provide feedback for the app.

Copy link

Your review app has been deployed and is available at 'http://172.214.61.236:80'.

Learn More about how to test and provide feedback for the app.

1 similar comment
Copy link

Your review app has been deployed and is available at 'http://172.214.61.236:80'.

Learn More about how to test and provide feedback for the app.

Copy link

Your review app has been deployed and is available at 'http://51.8.227.85:80'.

Learn More about how to test and provide feedback for the app.

1 similar comment
Copy link

Your review app has been deployed and is available at 'http://51.8.227.85:80'.

Learn More about how to test and provide feedback for the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants