Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type guards for internal types #3835

Draft
wants to merge 2 commits into
base: v11
Choose a base branch
from
Draft

Use type guards for internal types #3835

wants to merge 2 commits into from

Conversation

marvinhagemeister
Copy link
Member

Just a test to see if it affects performance.

@github-actions
Copy link

github-actions bot commented Dec 22, 2022

📊 Tachometer Benchmark Results

Summary

duration

  • 03_update10th1k_x16: unsure 🔍 -6% - +5% (-0.22ms - +0.19ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +1% (-4.65ms - +12.70ms)
    preact-local vs preact-master
  • filter_list: faster ✔ 0% - 4% (0.24ms - 11.48ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +11% (-0.72ms - +9.76ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -2% - +1% (-3.39ms - +1.26ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +1% (-0.23ms - +0.41ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -4% - +0% (-1.96ms - +0.07ms)
    preact-local vs preact-master

usedJSHeapSize

  • 03_update10th1k_x16: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.12ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -8% - +0% (-1.23ms - +0.03ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master

Results

03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.54ms - 3.82ms-unsure 🔍
-5% - +6%
-0.19ms - +0.22ms
preact-local3.52ms - 3.81msunsure 🔍
-6% - +5%
-0.22ms - +0.19ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.84ms - 3.85ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local3.85ms - 3.85msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1221.37ms - 1231.50ms-unsure 🔍
-1% - +0%
-12.70ms - +4.65ms
preact-local1223.42ms - 1237.50msunsure 🔍
-0% - +1%
-4.65ms - +12.70ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master26.85ms - 26.91ms-unsure 🔍
-0% - +0%
-0.12ms - +0.00ms
preact-local26.89ms - 26.99msunsure 🔍
-0% - +0%
-0.00ms - +0.12ms
-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master263.49ms - 272.47ms-slower ❌
0% - 4%
0.24ms - 11.48ms
preact-local258.74ms - 265.50msfaster ✔
0% - 4%
0.24ms - 11.48ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.86ms - 1.87ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local1.86ms - 1.87msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master86.82ms - 93.64ms-unsure 🔍
-10% - +1%
-9.76ms - +0.72ms
preact-local90.77ms - 98.73msunsure 🔍
-1% - +11%
-0.72ms - +9.76ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master14.55ms - 15.47ms-unsure 🔍
-0% - +9%
-0.03ms - +1.23ms
preact-local13.98ms - 14.83msunsure 🔍
-8% - +0%
-1.23ms - +0.03ms
-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master183.45ms - 187.06ms-unsure 🔍
-1% - +2%
-1.26ms - +3.39ms
preact-local182.73ms - 185.66msunsure 🔍
-2% - +1%
-3.39ms - +1.26ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master5.28ms - 5.28ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local5.28ms - 5.28msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master47.52ms - 48.03ms-unsure 🔍
-1% - +0%
-0.41ms - +0.23ms
preact-local47.67ms - 48.07msunsure 🔍
-0% - +1%
-0.23ms - +0.41ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.08ms - 1.09ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local1.09ms - 1.09msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
todo

duration

VersionAvg timevs preact-mastervs preact-local
preact-master44.67ms - 46.29ms-unsure 🔍
-0% - +4%
-0.07ms - +1.96ms
preact-local43.92ms - 45.14msunsure 🔍
-4% - +0%
-1.96ms - +0.07ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.13ms - 1.13ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local1.13ms - 1.14msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 99.436% when pulling 3debe02 on v11-guards into 4fe8287 on v11.

@github-actions
Copy link

Size Change: +175 B (0%)

Total Size: 37.8 kB

Filename Size Change
compat/dist/compat.js 3.56 kB +17 B (0%)
compat/dist/compat.umd.js 3.63 kB +16 B (0%)
dist/preact.js 4.59 kB +57 B (1%)
dist/preact.min.js 4.63 kB +54 B (1%)
dist/preact.umd.js 4.66 kB +31 B (0%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3.08 kB 0 B
debug/dist/debug.umd.js 3.17 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.umd.js 317 B 0 B
hooks/dist/hooks.js 1.47 kB 0 B
hooks/dist/hooks.umd.js 1.55 kB 0 B
jsx-runtime/dist/jsxRuntime.js 296 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 379 B 0 B
server/dist/server.js 2.6 kB 0 B
server/dist/server.umd.js 2.69 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.umd.js 522 B 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants