Undefined can clear checked and value properties for custom elements #3813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests makes it possible to reset the
value
andchecked
properties on a custom element, by passingundefined
as a prop value. Tests are added with the new behavior.This is a follow up on #2472 which slightly altered the behavior of #2465 in terms of undefined values. Currently an
undefined
value is never set for thevalue
andchecked
properties.We are using preact to render custom elements that uses properties to pass down data. The value can be cleared as a way to indicate an indeterminate state. I think it feels natural to allow the
value
andchecked
properties to function as any other property when it comes to custom elements.