Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add derekology/dev-governance-hooks to all-repos.yaml #964

Conversation

derekology
Copy link

dev-governance-hooks contains git hooks mainly to help with development governance. Currently, it includes hooks for advising/enforcing format standards for branch names and commit messages. I have more ideas in mind, but they will all be along the standards governance theme (e.g. ensuring commits are signed before push).

Note: The reject pattern feature of check-commit-msg is similar to the no-commit-to-branch hook, but extends it by allowing accept patterns as well, to enforce a specific format.

my new repository:

  • is added to the bottom or with existing repos from the same account
  • contains a license
  • is not language: system, language: script, language: docker, or language: docker_image
  • does not contain "pre-commit" in the name

@derekology
Copy link
Author

Sorry, I did not realize that renaming my branch would close the other PR. I re-opened this one with the new branch name, which reflects the updated project/repo name.

@asottile
Copy link
Member

  • check-commit-msg is better handled by other commit-msg linting tools -- your whole implementation can be replaced with a pygrep hook without needing any executing python
  • check-branch-name is too similar to (and easily confusable with) the same hook provided by pre-commit/pre-commit-hooks

so thank you for the PR but I cannot accept it, sorry

@asottile asottile closed this May 29, 2024
@derekology derekology deleted the add-derekology-dev-governance-hooks branch May 30, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants