Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit and home button added #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anikdhabal
Copy link

@anikdhabal anikdhabal commented Mar 29, 2023

Related to #91

Describe the changes you've made

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

< Describe_how_have_you_verified_the_changes_made >

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.

Screenshots (Images)

Before the changes After the Changes
<Upload_Screenshot> <Upload_Screenshot>

Recordings (Video with audio)

Before the changes After the Changes
<Upload_Recording> <Upload_Recording>

@netlify
Copy link

netlify bot commented Mar 29, 2023

Deploy Preview for arito ready!

Name Link
🔨 Latest commit 97d05a2
🔍 Latest deploy log https://app.netlify.com/sites/arito/deploys/64244fc9e070d10008058702
😎 Deploy Preview https://deploy-preview-93--arito.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your First Pull Request! Wish you best on your open-source journey 😊

@prakhartiwari0
Copy link
Owner

prakhartiwari0 commented Apr 4, 2023

This needs some UI changes. The location of buttons should be at a location where it is easily accessible by the user. Also, we need not use icons as they don't tell what the function of that button is, replace them with text. @anikdhabal

@prakhartiwari0
Copy link
Owner

Any updates @anikdhabal ?
I would need to close this PR if you are inactive. It has been a long time. Please reply under a day or two else I need to assign the issue to somebody else. Thank you

@anikdhabal
Copy link
Author

@prakhartiwari0 I will fix it by today.

@prakhartiwari0
Copy link
Owner

Any updates? @anikdhabal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants