Refs: #356;

We'll keep it here from now, as in 1.5 this might become obsolete due to #358

lib/earmark/line_scanner.ex

@@ -155,7 +155,11 @@ defmodule Earmark.LineScanner do
         [_, tag] = match
         %Line.HtmlOpenTag{tag: tag, content: line, indent: 0}
 
-      match = !recursive && Regex.run(~r/\A(\s{0,3})<\/([-\w]+?)>/, line) ->
+      # Is there potential for a DoS attack here, must check this match against
+      # input like:
+      #    "a</x</x</x</x ..." will it back up n time or is it clever enough
+      #    to check for a match at the end first?
+      match = !recursive && Regex.run(~r/\A(\s{0,3}).*<\/([-\w]+)>\z/, line) ->
         [_, leading_spaces, tag] = match
         %Line.HtmlCloseTag{tag: tag, indent: String.length(leading_spaces)}
 

test/acceptance/ast/html/block_test.exs

@@ -226,9 +226,16 @@ defmodule Acceptance.Ast.Html.BlockTest do
 
       assert as_ast(markdown) == {:error, ast, messages}
     end
-    test "however, this closes and keeps the garbage" do
+    test "new rule (tribute to, you know...) closing tag must be last one, but it ain't necessarily so (yet another tribute)" do
       markdown = "<div>\nline\n</div><hello>"
-      ast      = [{"div", [], ["line"], @verbatim}, "<hello>"]
+      ast      = [{"div", '', ["line"], %{meta: %{verbatim: true}}}, "<hello>"]
+      messages = [{:warning, 1, "Failed to find closing <div>"}]
+
+      assert as_ast(markdown) == {:error, ast, messages}
+    end
+    test "new rule (tribute to, you know...) closing tag must be last one, and is" do
+      markdown = "<div>\nline\n</hello></div>"
+      ast      = [{"div", [], ["line", "</hello>"], @verbatim}]
       messages = []
 
       assert as_ast(markdown) == {:ok, ast, messages}