Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Worker AMQP connection a Service #1000

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jerith
Copy link
Member

@jerith jerith commented Dec 7, 2015

This is necessary for #999.

@jerith jerith self-assigned this Oct 26, 2015
@jerith
Copy link
Member Author

jerith commented Oct 27, 2015

As part of this issue, I'm replacing txamqp (which is effectively unmaintained) with pika, which has support for a variety of I/O mechanisms (including Twisted plain Python stuff) and is actively maintained.

@smn
Copy link
Member

smn commented Oct 27, 2015

Wouldn't it be easier to first focus on splitting out the txamqp dependencies instead of also adding pika? I'm worried it'll be more difficult for people to follow along otherwise. And where's the code for this living?

@jerith
Copy link
Member Author

jerith commented Oct 27, 2015

The current iteration is in https://github.com/praekelt/vumi/tree/experiment/issue-1000-pika-based-service

The changes to the AMQP layer are pretty hefty even without swapping txamqp out for pika, and txamqp has enough undocumented oddities that I don't think it's really much extra effort to make the switch. I'm pretty sure the pika version will be cleaner and easier to understand, given the amount of time I've spent struggling with txamqp connection setup this week.

That said, this is still fairly experimental and I might end up dropping pika if it doesn't go as smoothly as I expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants