Refetch local metadata cache if corruption is detected #31509
+41
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses one of the points in ppy#31496. Not going to lie, this is mostly best-effort stuff (while the refetch is happening, metadata lookups using the local source *will* fail), but I see this as a marginal scenario anyways.
bdach
added
the
area:import
peppy
previously approved these changes
Jan 22, 2025
|
Seems to work well. I've applied some style changes, please check you're okay with the changes @bdach . |
bdach
commented
Jan 22, 2025
Comment on lines
126
to
127
| if (cacheDownloadRequest != null) | ||
| throw; |
There was a problem hiding this comment.
This looks like a behavioural change? I think this should return false? If the intention was to rethrow to the catch (Exception ex) block below then I'm not sure that's how this works.
In an isolated console project, when I do something like
try
{
throw new InvalidOperationException();
}
catch (InvalidOperationException)
{
throw;
}
catch
{
Console.WriteLine("caught");
}then the resulting program is not printing to the console, it's throwing the error:
Unhandled exception. System.InvalidOperationException: Operation is not valid due to the current state of the object.
at Program.<Main>$(String[] args) in /home/dachb/Documents/Projekty/ConsoleApp1/ConsoleApp1/Program.cs:line 5
There was a problem hiding this comment.
right, that's unfortunate. i thought that's how it worked but i guess not.
There was a problem hiding this comment.
Seems better now yeah.
peppy
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses one of the points in #31496.
Not going to lie, this is mostly best-effort stuff (while the refetch is happening, metadata lookups using the local source will fail), but I see this as a marginal scenario anyways.