Disable frame limiter dropdown when deemed appropriate

osu.Game/Localisation/RendererSettingsStrings.cs

@@ -0,0 +1,19 @@
+// Copyright (c) ppy Pty Ltd <[email protected]>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using osu.Framework.Localisation;
+
+namespace osu.Game.Localisation
+{
+    public static class RendererSettingsStrings
+    {
+        private const string prefix = @"osu.Game.Resources.Localisation.RendererSettings";
+
+        /// <summary>
+        /// "Frame limiters are unavailable in this combination of renderer and threading mode."
+        /// </summary>
+        public static LocalisableString FrameLimitersUnavailableTooltip => new TranslatableString(getKey(@"frame_limiters_unavailable_tooltip"), @"Frame limiters are unavailable in this combination of renderer and threading mode.");
+
+        private static string getKey(string key) => $@"{prefix}:{key}";
+    }
+}

osu.Game/Overlays/Settings/Sections/Graphics/RendererSettings.cs

@@ -3,6 +3,7 @@
 
 using System.Linq;
 using osu.Framework.Allocation;
+using osu.Framework.Bindables;
 using osu.Framework.Configuration;
 using osu.Framework.Extensions;
 using osu.Framework.Graphics;
@@ -21,12 +22,21 @@
 
         private bool automaticRendererInUse;
 
+        private Bindable<FrameSync> configFrameSync = null!;
+        private SettingsEnumDropdown<FrameSync> frameSyncDropdown = null!;
+
+        private IBindable<bool> allowConfiguringFrameLimiter = null!;
+
         [BackgroundDependencyLoader]
         private void load(FrameworkConfigManager config, OsuConfigManager osuConfig, IDialogOverlay? dialogOverlay, OsuGame? game, GameHost host)
         {
             var renderer = config.GetBindable<RendererType>(FrameworkSetting.Renderer);
             automaticRendererInUse = renderer.Value == RendererType.Automatic;
 
+            configFrameSync = config.GetBindable<FrameSync>(FrameworkSetting.FrameSync);
+
+            allowConfiguringFrameLimiter = host.AllowConfiguringFrameSync.GetBoundCopy();
+
             Children = new Drawable[]
             {
                 new RendererSettingsDropdown
@@ -40,10 +50,10 @@
                     Keywords = new[] { @"compatibility", @"directx" },
                 },
                 // TODO: this needs to be a custom dropdown at some point
-                new SettingsEnumDropdown<FrameSync>
+                frameSyncDropdown = new SettingsEnumDropdown<FrameSync>
                 {
                     LabelText = GraphicsSettingsStrings.FrameLimiter,
-                    Current = config.GetBindable<FrameSync>(FrameworkSetting.FrameSync),
+                    Current = configFrameSync.GetUnboundCopy(),
                     Keywords = new[] { @"fps" },
                 },
                 new SettingsEnumDropdown<ExecutionMode>
@@ -81,6 +91,28 @@
             });
         }
 
+        protected override void LoadComplete()
+        {
+            base.LoadComplete();
+
+            allowConfiguringFrameLimiter.BindValueChanged(v =>
+            {
+                frameSyncDropdown.Current.Disabled = !v.NewValue;
+                frameSyncDropdown.TooltipText = v.NewValue ? string.Empty : RendererSettingsStrings.FrameLimitersUnavailableTooltip;
+            }, true);
+
+            configFrameSync.BindValueChanged(val =>
+            {
+                bool disabled = frameSyncDropdown.Current.Disabled;
+
+                frameSyncDropdown.Current.Disabled = false;
+                frameSyncDropdown.Current.Value = val.NewValue;
+                frameSyncDropdown.Current.Disabled = disabled;
+            }, true);
+
+            frameSyncDropdown.Current.BindValueChanged(val => configFrameSync.Value = val.NewValue);
+        }
+
         private partial class RendererSettingsDropdown : SettingsEnumDropdown<RendererType>
         {
             protected override OsuDropdown<RendererType> CreateDropdown() => new RendererDropdown();