Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing ppy/osu#10682
The requirement is that we will try to standardise logs in the following format:
<timestamp> <log level> <calling class>, <event>, <key>:<value> <key>:<value> ...
The calling class is now recorded, though if required we can make this optional.
The
<key>:<value>
examples shown have two different variations:As a result, I've added two separate dictionaries respectively to support both; the first variation will be a
string
/object
dictionary for aname:value
input while the second variation will useobject
/object
to allow support forvalue changes
(e.g two integers, two strings, etc.).The
working beatmap: "Some beatmap name"
example was ignored (Even though it includes a little space after the:
) as it was probably meant to fall under the first variation.If both are specified into the log, then
from/to
takes precedence.This PR is currently to implement the functionality, but does not yet replace all instances where these two new optional parameters are to be used. I've added them to all methods and their overloads that uses the
add
method.