Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storing Codable data on UserDefaults #287

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Storing Codable data on UserDefaults #287

wants to merge 1 commit into from

Conversation

EgzonArifi
Copy link
Member

  • Implement resetValue method

@EgzonArifi
Implement storing data as Codable
703b3dc 
- Implement resetValue method
@EgzonArifi EgzonArifi requested a review from a team August 4, 2023 07:57
borut-t
borut-t reviewed Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@borut-t borut-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the actual benefit here?

yllfejziu
yllfejziu approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@yllfejziu yllfejziu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@borut-t
Copy link
Collaborator

borut-t commented May 7, 2024

@EgzonArifi can we add more tests to the suit? To test out other data types and codable as well...

ArminSpahic
ArminSpahic reviewed May 8, 2024
View reviewed changes
Tests/Tests/Core/Utilities/UserDefaults/UserDefaultTests.swift
Defaults.$screenName.resetValue()

// Then
XCTAssertEqual(Defaults.screenName, "default")
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please add additional tests that are covering other data types. It would be good to have an example for storing Codable data as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borut-t borut-t borut-t left review comments

@ArminSpahic ArminSpahic ArminSpahic left review comments

@yllfejziu yllfejziu yllfejziu approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
needs review requested changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EgzonArifi @borut-t @ArminSpahic @yllfejziu