Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

인기게시글-불러오기-기능-추가 #93

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

jobkaeHenry
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Unit test] 유닛테스트를 통과하지 못했습니다.

);
}

export default PopularPostCardList;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 코드는 PopularPostCardList 컴포넌트입니다. 다음은 코드 리뷰 내용입니다:

  1. 코드가 잘 구성되어있으며, 누락된 부분은 없습니다.

  2. 코드에 몇 가지 개선 사항이 있을 수 있습니다:

    • import 문을 알파벳순으로 정렬하는 것이 좋습니다.
    • getTokenFromLocalStorage 함수를 가져오기 전에 import 문을 추가하는 것이 좋습니다.
  3. 잠재적인 버그나 위험 요소는 없어 보입니다.

이상입니다! 혹시 추가 질문이 있으면 알려주세요.

@jobkaeHenry jobkaeHenry merged commit 11f70db into main Jan 5, 2024
1 check passed
@jobkaeHenry jobkaeHenry deleted the 인기게시글-불러오기-기능-추가 branch January 5, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant