Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tilde #79

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Handle tilde #79

wants to merge 4 commits into from

Conversation

anmolbabu
Copy link

This PR adds support for auto-completion of file paths starting ~ which
translate to user home dir

Signed-off-by: anmolbabu [email protected]

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #79 into master will decrease coverage by 3.97%.
The diff coverage is 54.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   89.93%   85.95%   -3.98%     
==========================================
  Files          14       15       +1     
  Lines         864      961      +97     
==========================================
+ Hits          777      826      +49     
- Misses         77      117      +40     
- Partials       10       18       +8
Impacted Files Coverage Δ
args.go 100% <100%> (ø) ⬆️
predict_files.go 95.12% <100%> (ø) ⬆️
test_utils.go 39.47% <39.47%> (ø)
utils.go 80% <90.9%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43c37e8...689e335. Read the comment docs.

@anmolbabu
Copy link
Author

@posener Please review

@coxley
Copy link

coxley commented Jun 4, 2021

@posener: Yo, could we get this and #80 reviewed + merged? :)

@posener
Copy link
Owner

posener commented Jun 10, 2021

Hi Codey,

Thanks for contributing!
I'm sorry, but I see some issues with this PR, and therefore I can't merge it.

  1. It is currently too complicated to be added to the code base. I would have want this implementation to be much simpler.
  2. I think it contains irrelevant changes?
  3. It conflicts with changes that already merged into the master branch?

If you want we can work on this PR together in order to make it possible to merge it.

@coxley
Copy link

coxley commented Oct 13, 2021

@posener Whoops! I should check GH more often. If I get some free cycles before anyone else does, I'd be happy to. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants