Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1138 starkware provider #90

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

1138 starkware provider #90

wants to merge 2 commits into from

Conversation

katien
Copy link
Contributor

@katien katien commented Mar 3, 2021

Introduces a starkware provider with method stubs matching the API we're planning on exposing

@mimafogeus2 mimafogeus2 changed the base branch from 1136-sdk-split to develop March 17, 2021 09:42
@mimafogeus2 mimafogeus2 changed the base branch from develop to 1136-sdk-split March 17, 2021 09:50
@mimafogeus2 mimafogeus2 changed the base branch from 1136-sdk-split to develop March 17, 2021 09:55
* Demo code - logic will be moved into the widget in a later ticket
* Do we want to allow users to supply application/index/ethaddress?
* */
getStarkKey() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be added somewhere else. No reason to push it just to delete it one PR later.

@@ -13,7 +13,8 @@
"sourceMap": true,
"inlineSources": true,
"noUnusedLocals": true,
"strictNullChecks": true
"strictNullChecks": true,
"allowSyntheticDefaultImports": true // required for starkware-crypto BigNumber import
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really required?
From what I read, allowSyntheticDefaultImports allows to use import x from 'x' instead of import * as x from 'x'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants