Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annualized quote change column #4303

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

OnkelDok
Copy link
Member

@OnkelDok OnkelDok commented Oct 24, 2024

Hey, finally I found time to do a fresh installation of the development (because with installed one I get build errors). So here a first change proposal:

Sometimes for a security I want see and compare the annualized quote change. Especially when looking at higher intervals (>1 year), then with an annualized value it's easier to get an idea of the yearly increase, which is normally a good indicator for financial products.

So here a first sample as draft. If @buchen generally accepts this new column then I would continue the work (translations etc.).

Suggestions for (better) naming of the column (label, header, description) are welcome.

grafik

@OnkelDok
Copy link
Member Author

@buchen: I don't know if you noticed this draft PR. Please give a short feedback (thumbs up or down) if these kind of columns would find a way into the software or not. If yes, then I will continue and finish the work on this PR.
Thanks in advance!

@OnkelDok OnkelDok force-pushed the quote_change_annualized branch from 352bd62 to b0ddf35 Compare January 3, 2025 16:26
@OnkelDok OnkelDok force-pushed the quote_change_annualized branch from 7fce544 to 87e1f98 Compare January 4, 2025 20:08
@OnkelDok
Copy link
Member Author

OnkelDok commented Jan 4, 2025

I've now added labels and translations.
According to the label of the annualized TTWROR column (TTWROR p.a. 2 Jahre) I used the same format (Δ p.a. 2 Jahre).
If the format like in my initial screenshot is better (Δ 2 Jahre (p.a.)), then I can change this.

@buchen If you want see more reuse of code, then maybe we can create a class for the price change columns (normal an annualized) because a lot of code lines are the same. Only the final calculation and the labels and column ident is different.

@OnkelDok OnkelDok marked this pull request as ready for review January 4, 2025 20:18
@OnkelDok OnkelDok requested a review from buchen January 4, 2025 20:18
@OnkelDok OnkelDok changed the title [WIP] annualized quote change column Annualized quote change column Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Under Consideration
Development

Successfully merging this pull request may close these issues.

2 participants