forked from rust-windowing/softbuffer
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase on upstream master branch #1
Open
zinifier
wants to merge
153
commits into
pop-os:cosmic
Choose a base branch
from
zinifier:argb8888
base: cosmic
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `Context` is created with a display handle, and a `Surface` is created with a `&Context` and a window handle. Thus multiple windows can be created from the same context without duplicating anything that can be shared. This API is broadly similar to `wgpu` or `glutin`. On Wayland, the `Context` contains the `EventQueue`, which is shared between windows, and the `WlShm` global. On X11, `Context::new` checks for the availability of XShm, and contains a bool representing that as well as the `XCBConnection`. The shared context data is stored within the window in an `Arc`. On other platforms, the display isn't used and `Context` is empty. This does however test that the display handle has the right type on those platforms and fail otherwise. Previously the code didn't test that. Closes rust-windowing#37.
…ow-split Split display/window wrappers
…indow is on a new screen cc rust-windowing#67
…cking scale factor in set_buffer works
…on-setbuffer mac: Fix layer scale not being updated when contents is updated and window is on a new screen
fix: update width and height when resizing buffer
Fix changelog link
Using the latest `winit` version in examples fixes resizing behavior on Wayland, so the workaround for that in the `winit` example is also removed here.
Update dependencies
This makes it easy to run examples with the web backend, in the same way that winit examples are run.
Add `run-wasm` workspace member, as used in `winit`
raw-window-handle bumped MSRV, so should we
This is based on the API that will be used for no-copy presentation. But wraps it in `set_buffer`. This also fixes the Wayland buffer code to set `self.width` and `self.height` on resize, and set the length of the shared memory file when the buffer is created. Co-authored-by: jtnunley <[email protected]>
Update `windows-sys` and `image`
Fix multi-threaded Wasm
Fix atomic Wasm CI
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: John Nunley <[email protected]>
Previously, types in softbuffer were !Send and !Sync. However it would be nice if types could be shared across threads. Therefore I've made the following changes: - Context<D> is Send+Sync iff D is Send+Sync - Surface<D, W> is Send iff D is Send+Sync and W is Send - Buffer<'x, D, W> is Send iff D if Send+Sync and W is Send Materially, I've made the following changes across the backends: - X11, Wayland and KMS use Arc for their displays instead of Rc. - MacOS uses MainThreadBound to secure windowing resources. This restriction was already implicitly enforced anyhow. - Windows creates a thread specifically for allocating and then deallocating device contexts. This lets us get around the thread affinity problem. Closes rust-windowing#205 Signed-off-by: John Nunley <[email protected]> Co-authored-by: Mads Marquart <[email protected]>
Signed-off-by: John Nunley <[email protected]>
- Remove the default features of the image crate. - Remove exr from pinned deps - Fix macro positioning - Allow for clippy false positive Signed-off-by: John Nunley <[email protected]>
This can lead to weird results in some cases, but it's better than crashing. Once we have a better format API we can work around this. ref rust-windowing/winit#3646 Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
…to fix autoformatting Via `include!()` `rustfmt` doesn't know that this file belongs to the current project and doesn't autoformat it. Furthermore, jump-to-symbol likely doesn't play that well with `include!()`. Without creating a `lib.rs` file in `utils/`, use `#[path]` to reference the existing file without following a `mod`ule hierarchy. Note that the file remains in the `utils/` folder as that doesn't get picked up by `autoexamples`.
And exclude Orbital from it as it requires nightly anyway.
Updates the requirements on [core-graphics](https://github.com/servo/core-foundation-rs) to permit the latest version. - [Commits](servo/core-foundation-rs@core-graphics-v0.23.1...core-graphics-v0.24.0) --- updated-dependencies: - dependency-name: core-graphics dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…cargo/core-graphics-0.24.0 build(deps): update core-graphics requirement from 0.23.1 to 0.24.0
Updates the requirements on [windows-sys](https://github.com/microsoft/windows-rs) to permit the latest version. - [Release notes](https://github.com/microsoft/windows-rs/releases) - [Commits](microsoft/windows-rs@0.52.0...0.59.0) --- updated-dependencies: - dependency-name: windows-sys dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Currently inactive while getting assigned as a reviewer on every single PR.
Add support for iOS / UIKit, and clean up CoreGraphics impl
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
* Reformat on Rust 1.83 * Disable doc tests on Rust 1.83 * Fix mutability error in Orbital backend * Appease Clippy Co-authored-by: Marijn Suijten <[email protected]>
On Android the backing buffer (`NativeWindow`) disappears when the application is not focussed and/or the screen is locked. Winit handles this by requiring apps to create their `raw_window_handle()` consumers _after_ `Event::Resumed` and to clean it up _before_ returning from `Event::Suspended`. For consistency Winit also sends `Resumed` on all other platforms during init.
This was referenced Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of the three different commits on this branch:
Cannot be merged automatically because the history has been rewritten. Feel free to ignore this PR and rebase/merge however you like.
Updating to latest softbuffer will fix problems when trying to start on Xorg on some hardware: rust-windowing#215
Note: pop-os/iced depends on a specific tag, not this cosmic branch