-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Rework resize operations with resize mode #1486
base: master_jammy
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of problems on 1083bdd:
- The Super-Enter shortcut still works to enter window management mode, but doesn't allow resizing windows anymore; with no visual indication, this is going to be confusing to current users upgrading.
- With two windows split horizontally on a 1080p display, I can can only make a window larger without holding shift, and I can only make a window smaller while holding shift; the arrow indicators seem to indicate that I should be able to use the left or right arrow key in either mode (with the only difference being inverted while holding shift.)
- Upon reading your description again, I understand the reason this isn't working is because I can't grow a window against the edge of a display; perhaps the on-screen arrow indicators should only be present for directions where resizing is possible, or else maybe the control scheme could use further consideration.
Separately from these issues, a change like this is going to need @pop-os/ux input/approval.
1083bdd
to
bbdea35
Compare
The new arrow placement is easier to understand: simplescreenrecorder-2022-08-10_09.49.47.mp4It does seem strange that I need to e.g. use Shift in order to be able to use two of the arrow keys, and release Shift to be able to use the other two, in the above example. It makes me wonder why I need shift at all. Of course, the reason is that sometimes a window has three or more resizeable edges: simplescreenrecorder-2022-08-10_09.51.26.mp4But still feels a little strange. These points still stand:
|
Waiting for new designs from UX for these issues |
Pressing Super + R will now enter a resize mode, which has a visual indicator to show whether the resizes will grow or shrink the window. Arrow keys and hjkl will grow the window in the four directions by default. Holding Shift will invert the arrows and allow shrinking the window from the four sides.