Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show desktop entry actions in right click menu #643

Merged

Conversation

joshuamegnauth54
Copy link
Contributor

@joshuamegnauth54 joshuamegnauth54 commented Nov 5, 2024

Currently, desktop entries display a generic menu with items that aren't relevant to apps. This patch improves the menu by removing the unneeded items and listing desktop specific entries such as desktop actions. For example, for Firefox the right click menu now lists the actions to open private windows (et cetera).

Should compose well with pop-os/cosmic-applibrary#179

Before:

before

After:

after

I also updated the code to re-add the copy and cut entries. The picture above is outdated.

@joshuamegnauth54 joshuamegnauth54 force-pushed the desktop-entry-menu-for-desktop branch from 4bc1285 to 6b9a2a4 Compare November 6, 2024 08:35
@joshuamegnauth54 joshuamegnauth54 marked this pull request as ready for review November 7, 2024 06:50
Currently, desktop entries display a generic menu with items that aren't
relevant to apps. This patch improves the menu by removing the unneeded
items and listing desktop specific entries such as actions. For example,
right clicking a Firefox desktop entry will show the action to open a
private tab.

Should compose well with pop-os/cosmic-applibrary#179
@joshuamegnauth54 joshuamegnauth54 force-pushed the desktop-entry-menu-for-desktop branch from 6b9a2a4 to 0f60ffa Compare November 8, 2024 03:19
@joshuamegnauth54 joshuamegnauth54 changed the title Improved desktop entry menu Show desktop entry actions in right click menu Nov 10, 2024
@jackpot51 jackpot51 merged commit 5be3a95 into pop-os:master Nov 10, 2024
@joshuamegnauth54 joshuamegnauth54 deleted the desktop-entry-menu-for-desktop branch November 11, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants