Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump submodules #186

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

jokeyrhyme
Copy link
Contributor

  • ran git submodule foreach --recursive 'git fetch; (git checkout master_jammy || git checkout master); (git pull origin master_jammy || git pull origin master);'
  • ran rm -rf ~/.cargo/git ~/.cargo/registry and just clean to make sure I was testing against currently-available commits in GitHub and not something I had cached locally
  • confirmed that just sysext still works
  • end-to-end test from cosmic-greeter into cosmic-session:

@jokeyrhyme
Copy link
Contributor Author

jokeyrhyme commented Jan 17, 2024

Interestingly, alacritty, cosmic-term and wezterm all seem to not be redrawing themselves on each keyboard input or something: I can type a few keys in the shell prompt and not see any of those keys reflected visually, but then move the mouse outside of the window and then back over it and redrawing is triggered

If I wait a few seconds and keep typing, the terminal does sometimes redraw without having to touch the mouse, strange...

Oh, the unexpected behaviour is only happening when the mouse is over the terminal window, tools like top and btm show that redrawing is happening as expected provided the mouse is elsewhere

And this isn't happening in Firefox as I type this comment either: here my keyboard input is shown on the screen immediately

Update: okay, I can't reproduce this anymore, not sure what happened, but I've run pacman -Syu since that initial test, so maybe some non-COSMIC component was the cause 🤷

@jokeyrhyme jokeyrhyme marked this pull request as draft January 19, 2024 23:22
@jokeyrhyme jokeyrhyme force-pushed the bump-submodules-2024-01-17 branch from 25b0f2e to 025838e Compare January 23, 2024 00:22
@jokeyrhyme jokeyrhyme marked this pull request as ready for review January 23, 2024 00:30
@jokeyrhyme
Copy link
Contributor Author

Okay, I've updated all the submodule references again now that those PRs are merged, and everything passes all the manual testing from before

Love the new cosmic-screenshot capabilities and the display settings in cosmic-settings :)

@jokeyrhyme jokeyrhyme mentioned this pull request Jan 23, 2024
@Drakulix Drakulix merged commit 3cd45d1 into pop-os:master Jan 23, 2024
1 check passed
@jokeyrhyme jokeyrhyme deleted the bump-submodules-2024-01-17 branch January 23, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants