Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Turkish translation #146

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Update Turkish translation #146

merged 1 commit into from
Jul 31, 2024

Conversation

Beryesa
Copy link
Contributor

@Beryesa Beryesa commented Jul 30, 2024

Fix little mistakes and bring it closer to the established translations by the GNOME and KDE Turkish teams for consistency.

@Beryesa
Copy link
Contributor Author

Beryesa commented Jul 31, 2024

I should note however that cosmic-library-home doesn't fit (Kitaplık Ana Sayfası)
resim

Should we call it just "Home" (Ana Sayfa) or just "Library" or are there any other plans about longer strings in the UI? :P

@wash2
Copy link
Collaborator

wash2 commented Jul 31, 2024

Just "Home" would be fine for now. It's a bit awkward to have long names for these buttons. Maybe the text could be made to wrap, and buttons all increase in size to match the largest button height.

@Beryesa
Copy link
Contributor Author

Beryesa commented Jul 31, 2024

Hey, just before merging that, I see a string is missing in

text("Add group")

Should I make another PR for that, or can I extend this one?
Something like text(&fl!("add-group").as_str()) and adding that key to the files helps
resim

Kindly, @wash2

@Beryesa
Copy link
Contributor Author

Beryesa commented Jul 31, 2024

Here, #147
I can add it here after that one's merged.

@Beryesa
Copy link
Contributor Author

Beryesa commented Jul 31, 2024

Thanks, that was fast! xP
Updated to include it as well.
resim

Fix little mistakes and bring it closer to
the established FOSS translations for consistency

Signed-off-by: Berk Elyesa Yıldırım <[email protected]>
@wash2 wash2 merged commit 1963ce3 into pop-os:master Jul 31, 2024
1 check passed
@Beryesa Beryesa deleted the update-tr-i18n branch July 31, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants