Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xworkspaces): Add option to disable scroll wrap #2858

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Cationiz3r
Copy link

@Cationiz3r Cationiz3r commented Nov 5, 2022

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Added option enable-wrap (enabled by default) for the xworkspaces module. When disable, scrolling the module at the last workspace will not return you to the first, and vice versa.

Related Issues & Documents

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

You can add this at the end of the Basic settings section:

; Wrap the last workspace to the first one
; Default: true
wrapping-scroll = false

src/modules/xworkspaces.cpp Outdated Show resolved Hide resolved
src/modules/xworkspaces.cpp Outdated Show resolved Hide resolved
@patrick96
Copy link
Member

Please also add a changelog entry: https://github.com/polybar/polybar/blob/master/CONTRIBUTING.md#changelog

Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a compiler warning, but otherwise looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants