Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/xwindow show all windows #2856

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

haritkapadia
Copy link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

This PR adds the ability to display all windows in the current workspace using the internal/xwindow module (rather than just the active workspace). It adds the following config options to enable this behaviour:

label: %title%
label-active: %title%
label-foreground: #aaaaaa
label-active-foreground: #ff0000
label-padding: 1
label-active-padding: 1
enable-click = true
enable-scroll = true
reverse-scroll = true

I have some extra commentary so I'm adding it here.

  • I could not compile the project after running clangformat on the whole project.
  • I believe this code would be better suited for the internal/xworkspaces module since it shares information and configuration. However, I really wanted this feature *now*, so I put it where I thought was easiest to code.
  • I added a new function to ewmh_util that sets an active window.

Related Issues & Documents

#448

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
    The added config options need to be documented. The are names and behaviours are the same as the internal/xworkspaces module.
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

This commit adds the following behaviours.

- List all windows in current workspace instead of just the active one
- Use click and scroll to focus a different window
- Use different labels no windows, active window, and other windows
This reverts commit 08a68f9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant