This repository has been archived by the owner on Oct 14, 2023. It is now read-only.
Enable faster parallel testing #1556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrojuanlu
suggested changes
Jul 23, 2022
There was a problem hiding this comment.
Nice! I recall talking about this some months ago, and @jorgepiloto and I discussed it last week again.
However, this did make CI a bit more than 1.5x slower, so I'd rather find another solution. Besides, it would be nice to have this for -slow tests too. I think there are other ways to achieve this in tox.ini, I can investigate a bit.
|
Quick and dirty: Add a (parallel) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It automatically scales to the number of cores that a machine has, so it should not break single-core-CI. As a bonus, if you have a laptop, it checks if its cooling is sufficient ;)
For this change to take effect, cached tox environments must be updated or removed and recreated.
Nice to have on a few more cores.
tox -e py310-fastpasses in 1:24 without and in 0:41 with this change applied on my system. "Your mileage may vary."