Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve type annotations during normalization #382

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Conversation

timsueberkrueb
Copy link
Collaborator

See #341. We now dismiss type annotations during unification, i.e. only after normalization.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 37.00000% with 63 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lang/elaborator/src/normalizer/val.rs 27.27% 32 Missing ⚠️
lang/elaborator/src/normalizer/eval.rs 34.04% 31 Missing ⚠️
Files with missing lines Coverage Δ
lang/ast/src/exp/anno.rs 90.38% <100.00%> (+9.61%) ⬆️
lang/elaborator/src/normalizer/env.rs 87.36% <ø> (+0.91%) ⬆️
lang/elaborator/src/result.rs 34.54% <ø> (+1.78%) ⬆️
lang/elaborator/src/unifier/unify.rs 86.16% <100.00%> (+1.29%) ⬆️
lang/elaborator/src/normalizer/eval.rs 77.82% <34.04%> (-7.21%) ⬇️
lang/elaborator/src/normalizer/val.rs 44.47% <27.27%> (-0.24%) ⬇️

... and 1 file with indirect coverage changes


🚨 Try these New Features:

@BinderDavid BinderDavid merged commit 9bd143a into main Nov 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants