Fix OpenURL crash on macOS Sequoia #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| @available(iOS 14, macOS 11, tvOS 14, watchOS 7, *) | |||
| private enum OpenURLKey: DependencyKey { | |||
| static let liveValue = OpenURLEffect { url in | |||
| static let liveValue = OpenURLEffect { @MainActor url in | |||
There was a problem hiding this comment.
Suggested change
| static let liveValue = OpenURLEffect { @MainActor url in | |
| // NB: This must be annotated '@MainActor' to avoid a Swift bug: | |
| // https://github.com/pointfreeco/swift-dependencies/discussions/301 | |
| static let liveValue = OpenURLEffect { @MainActor url in |
|
@beetee17 Thanks, and sorry for the delay! This time of year has been busy. Do you think it's possible to get a unit test in place that demonstrates the problem? Ideally we would have CI catch any regressions if someone were to refactor away that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the discussion at #301 for details.