Record state access when constructing _StoreCollection. #3521
Conversation
| store._$observationRegistrar.access(store, keyPath: \.currentState) | ||
| self.data = store.withState { $0 } |
There was a problem hiding this comment.
This definitely fixes the problem, but I am also wondering if we should be dropping the _withoutPerceptionChecking from withState as an alternative fix. We introduced withState back in the view store days to give people easy access to state when observation wasn't needed. But now with implicit observation everywhere, should we be tracking those accesses with the registrar?
There was a problem hiding this comment.
The only reason not to do this that I can think of is that it's a big behavior change for folks not using @ObservableState, and they could get really inefficient SwiftUI observation wherever they decide to use withState. I think 2.0 will give us a nice opportunity here to opt into @ObservableState by default and avoid these questions entirely.
This fixes an issue brought up in #3518. When constructing a
_StoreCollection, like for aForEach, we should record a state access with the registrar. Currently we usewithState, which silently accesses state, and so one will not get perception warnings if they forget to useWithPerceptionTracking.