Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint dates now correctly set for 2023 #22

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

finnveloz
Copy link
Contributor

No description provided.

@ktohalloran ktohalloran changed the base branch from main to print_bullet_points May 1, 2024 14:40
Copy link
Collaborator

@ktohalloran ktohalloran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! I didn't get a chance to test it though, so let's do that together today.

Comment on lines +37 to +39
if(first_day_of_year.weekday()==6):
while first_day_of_year.weekday() != 0: # 0 represents Monday
first_day_of_year += timedelta(days=1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk about what this is doing during our meeting today.


iso_calendar_info = today.isocalendar()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

Comment on lines +21 to +22
#if first day of year is thursday or later, the isocalendar method i am using will not count that week as a week
##so this code counts it as a week if it starts on any day other than saturday
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great explanation!

Base automatically changed from print_bullet_points to main May 1, 2024 16:24
@ktohalloran ktohalloran changed the base branch from main to dev May 10, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants