Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(accordion): implementa definições do AnimaliaDS #1827

Merged
merged 1 commit into from
Oct 6, 2023
Merged

feat(accordion): implementa definições do AnimaliaDS #1827

merged 1 commit into from
Oct 6, 2023

Conversation

CSimoesJr
Copy link
Contributor

@CSimoesJr CSimoesJr commented Sep 27, 2023 •
edited by rafaellmarques
Loading

ACCORDION

DTHFUI-7691

PR Checklist [Revisor]

  • Padrão de Commit (Coeso, de acordo com o que está sendo realizado)
  • Código (Boas práticas, nome de variavéis/métodos, etc.)
  • Testes unitários (Cobre a situação implementada e coverage está mantido)
  • Documentação (Clara, objetiva e com exemplos caso necessário)
  • Samples (A implementação possui exemplo no Labs/Caso de uso)
  • Rodado em navegadores suportados (Chrome, FireFox, Edge)

implementa definições do AnimaliaDS

Simulação
app.zip

Styles para testar tokens no App:
styles.zip

Testar samples, documentação e customização
Style: po-ui/po-style#451
Theme-totvs: totvs/po-theme-totvs#257

@CSimoesJr CSimoesJr force-pushed the accordion/DTHFUI-7691 branch from 3b48277 to 62cdbad Compare September 27, 2023 14:29
@CSimoesJr CSimoesJr force-pushed the accordion/DTHFUI-7691 branch 2 times, most recently from f762dce to dd63511 Compare September 28, 2023 19:07
@CSimoesJr CSimoesJr removed the hacktoberfest-accepted Aceito para a hacktoberfest label Sep 28, 2023
felipepetuco
felipepetuco previously approved these changes Sep 29, 2023
View reviewed changes
jcorrea97
jcorrea97 previously approved these changes Oct 4, 2023
View reviewed changes
@CSimoesJr
feat(accordion): implementa definições do AnimaliaDS
f2e14e5 
Implementa definições do AnimaliaDS no Accordion

fixes DTHFUI-7691
@CSimoesJr CSimoesJr dismissed stale reviews from jcorrea97 and felipepetuco via f2e14e5 October 6, 2023 19:35
@CSimoesJr CSimoesJr force-pushed the accordion/DTHFUI-7691 branch from dd63511 to f2e14e5 Compare October 6, 2023 19:35
@rafaellmarques rafaellmarques merged commit 79d15f2 into master Oct 6, 2023
7 checks passed
@rafaellmarques rafaellmarques deleted the accordion/DTHFUI-7691 branch October 6, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcorrea97 jcorrea97 jcorrea97 approved these changes

@jnrpalma jnrpalma jnrpalma approved these changes

@rafaellmarques rafaellmarques rafaellmarques approved these changes

@felipepetuco felipepetuco felipepetuco left review comments

Assignees
No one assigned
Labels
contribution hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CSimoesJr @rafaellmarques @jnrpalma @jcorrea97 @felipepetuco