Skip to content

Commit

Permalink
fix(page-job-scheduler): corrige erro quando 'firstExecution' undefined
Browse files Browse the repository at this point in the history
Corrigo erro quando 'firstExecution' é definido como undefined

fixes DTHFUI-10385
  • Loading branch information
anderson-gregorio-totvs committed Dec 5, 2024
1 parent d77f819 commit 214163d
Show file tree
Hide file tree
Showing 3 changed files with 51 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -786,4 +786,22 @@ describe('PoPageJobSchedulerComponent:', () => {
expect(executionElementHiddenAttribute).toBeFalsy();
});
});

it(`getSteps: should use 'literals' when the parameterization step title is not defined`, () => {
const mock = Object.assign(new QueryList(), {
_results: [{}, {}],
length: 1
}) as QueryList<PoJobSchedulerParametersTemplateDirective>;

component.parametersTemplate = mock;
component['getSteps']();

const result = component['steps'].slice(1, -1);
const resultExpected = [
{ label: `${component['literals']['parameterization']} 1` },
{ label: `${component['literals']['parameterization']} 2` }
];

expect(result).toEqual(resultExpected);
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,25 @@ describe('PoPageJobSchedulerService:', () => {
expect(poPageJobSchedulerService['removeInvalidKeys']).toHaveBeenCalledWith(jobSchedulerInternal);
});

it(`convertToJobScheduler: should ignore when 'firstExecutionHour' is set but 'firstExecution' is not set`, () => {
const jobSchedulerInternal = {
executionParameter: 'value',
firstExecution: undefined,
firstExecutionHour: '15:30',
processID: '1'
};

const jobSchedulerInternalExpected = {
executionParameter: 'value',
firstExecution: undefined,
processID: '1'
};

const result = <any>poPageJobSchedulerService['convertToJobScheduler'](jobSchedulerInternal);

expect(result).toEqual(jobSchedulerInternalExpected);
});

it(`convertToJobSchedulerInternal: should set 'jobSchedulerInternal.firstExecutionHour' with 'getHourFirstExecution'
return if 'firstExecution' is defined`, () => {
const jobSchedulerInternal = {
Expand Down Expand Up @@ -483,6 +502,7 @@ describe('PoPageJobSchedulerService:', () => {

expect(result).toEqual(jobSchedulerInternalExpected);
});

it(`convertToJobSchedulerInternal: should return the merge between 'jobSchedulerInternal' and
the return from 'convertToPeriodicityInternal'`, () => {
const jobSchedulerInternal = {
Expand Down Expand Up @@ -788,6 +808,15 @@ describe('PoPageJobSchedulerService:', () => {
);
});

it(`replaceHourFirstExecution: should replace hour add time zone`, () => {
const stringDate = new Date().toString();
const timeZone = `${stringDate.substring(28, 31)}:${stringDate.substring(31, 33)}`;

const result = `2025-12-24T23:59:00${timeZone}`;

expect(poPageJobSchedulerService['replaceHourFirstExecution']('2025-12-24', '23:59')).toBe(result);
});

it('returnValidExecutionParameter: should remove keys that have undefined value', () => {
const parameter = {
numberKey: 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,10 @@ export class PoPageJobSchedulerService {
}

private replaceHourFirstExecution(date: string, time: string): string {
if (!date) {
return date;
}

const dateSplited = date.split('-');
const year = parseInt(dateSplited[0]);
const monthIndex = parseInt(dateSplited[1]) - 1;
Expand Down

0 comments on commit 214163d

Please sign in to comment.