Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing auth token in registries with paths included #7337

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

nachoaldamav
Copy link
Contributor

@nachoaldamav nachoaldamav commented Nov 21, 2023

close #5970
close #2933

@zkochan zkochan merged commit 23039a6 into main Nov 21, 2023
14 of 18 checks passed
@zkochan zkochan deleted the fix-missing-auth-token-registry branch November 21, 2023 21:03
GiladShoham added a commit to teambit/bit that referenced this pull request Nov 27, 2023
Related: pnpm/pnpm#7337

## Proposed Changes

- Fix authentication issue

Co-authored-by: Gilad Shoham <[email protected]>
@dparish
Copy link

dparish commented Dec 11, 2023

I still see this with GitHub private repos.

~/.npmrc

//npm.pkg.github.com:443/:_authToken=ghp_BLAHBLAH

And in my ppm project's root directory I have a .npmrc with:

@org:registry=https://npm.pkg.github.com:443/

where @org is my org

I've tried every combination of trailing slashes, 443's etc all to no avail.

pnpm --version
8.12.0
node --version
v20.3.1

@nachoaldamav
Copy link
Contributor Author

Hi @dparish, I'll check it today.

@nachoaldamav
Copy link
Contributor Author

@dparish I just tested it myself and it works for me, even with the port specified, what's the error you have?

//npm.pkg.github.com:443/:_authToken=<TOKEN>
@nachoaldamav:registry=https://npm.pkg.github.com:443/

@dparish
Copy link

dparish commented Dec 12, 2023

OH LORD I'M AN IDIOT

My token had expired....

Well at least I downloaded ppm, built it and experimented with logging to try and fix something that wasn't even broken :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants