Update generic-yearly-gantt-chart-with-today.json #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hope I'm doing this right (this is my first time editing on GitHub). I've updated the JSON so that the Gantt chart now correctly renders when Start and End dates are outside the timeframe of the current year. That is, if the Start and/or End dates are before 1st January of current year, as well as if Start and/or End dates are after 31st December of current year.
|
Thank you for the update and for sending the pull request @DRVRogo 🙏✨ |
tecchan1107
reviewed
Oct 23, 2022
| "left": "= floor(((Number(@now)-Number(Date('' + getYear([$Start]) + '/1/1')))/(1000*60*60*24))/365 * 100) + '%'" | ||
| "left": "= floor(((Number(@now)-Number(Date('' + getYear(@now) + '/1/1')))/(1000*60*60*24))/365 * 100) + '%'" |
There was a problem hiding this comment.
Modifying [$Start] to @now, for example, would cause a red line to appear representing today, even if the schedule is for next year.
How about reverting back to the previous state so that only this year's schedule shows the red line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to generic-yearly-gantt-chart-with-today.json
What's in this Pull Request?
Updates generic-yearly-gantt-chart-with-today.json so that the Gantt chart now correctly renders when Start and End dates are outside the timeframe of the current year. That is, if the Start and/or End dates are before 1st January of current year, as well as if Start and/or End dates are after 31st December of current year.