do not use .defaultPrevented

pmndrs · Nov 4, 2024 · c42e52b · c42e52b
1 parent e11259f
commit c42e52b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 16 deletions.
diff --git a/packages/uikit/src/components/input.ts b/packages/uikit/src/components/input.ts
@@ -356,7 +356,7 @@ export function computedSelectionHandlers(
     }
     return {
       onPointerDown: (e) => {
-        if (dragState != null || e.defaultPrevented || e.uv == null || instancedTextRef.current == null) {
+        if (dragState != null || e.uv == null || instancedTextRef.current == null) {
           return
         }
         cancelBlur(e.nativeEvent)
@@ -372,7 +372,7 @@ export function computedSelectionHandlers(
         setTimeout(() => focus(startCharIndex, startCharIndex))
       },
       onDoubleClick: (e) => {
-        if (segmenter == null || e.defaultPrevented || e.uv == null || instancedTextRef.current == null) {
+        if (segmenter == null || e.uv == null || instancedTextRef.current == null) {
           return
         }
         e.stopImmediatePropagation?.()
@@ -396,12 +396,7 @@ export function computedSelectionHandlers(
       onPointerLeave: onPointerFinish,
       onPointerCancel: onPointerFinish,
       onPointerMove: (e) => {
-        if (
-          dragState?.pointerId != e.pointerId ||
-          e.defaultPrevented ||
-          e.uv == null ||
-          instancedTextRef.current == null
-        ) {
+        if (dragState?.pointerId != e.pointerId || e.uv == null || instancedTextRef.current == null) {
           return
         }
         e.stopImmediatePropagation?.()

diff --git a/packages/uikit/src/events.ts b/packages/uikit/src/events.ts
@@ -2,8 +2,6 @@ import { Intersection } from 'three'
 
 export type ThreeEvent<TSourceEvent> = Intersection & {
   nativeEvent: TSourceEvent
-  defaultPrevented?: boolean
-  stopped?: boolean
   stopPropagation?: () => void
   stopImmediatePropagation?: () => void
 } & (TSourceEvent extends { pointerId: number } ? { pointerId: number } : {})

diff --git a/packages/uikit/src/scroll.ts b/packages/uikit/src/scroll.ts
@@ -241,9 +241,6 @@ export function computedScrollHandlers(
       onPointerLeave: onPointerFinish,
       onPointerCancel: onPointerFinish,
       onPointerMove: (event) => {
-        if (event.defaultPrevented) {
-          return
-        }
         const prevInteraction = downPointerMap.get(event.pointerId)
         if (prevInteraction == null) {
           return
@@ -277,9 +274,6 @@ export function computedScrollHandlers(
         prevInteraction.timestamp = timestamp
       },
       onWheel: (event) => {
-        if (event.defaultPrevented) {
-          return
-        }
         const { nativeEvent } = event
         scroll(event, nativeEvent.deltaX, nativeEvent.deltaY, undefined, false)
       },