react_refresh: Rewrite main loop #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since atoms created in a function context are new atoms, there's nothing in the arrow function sub-tree that we should transform. The default behavior seems to be to visit everything, whereas an empty impl stops the walk. Another driveby fix: store previous `top_level` in `visit_mut_stmts` instead of always resetting it to `true`. I don't have a failing test for this (so it might be fine), but it's a pattern that's explicitly called out in the docs [0]. [0]: https://swc.rs/docs/plugin/ecmascript/cheatsheet#make-your-handlers-stateless Fixes pmndrs#36
This turned into an all-in-one commit: * Move the logic to the `visit_mut_*` functions from VisitMut. * Make atom key names more flexible to support e.g. pmndrs#26 The largest change is the fact that we perform most of the work directly in the visitor functions. For applicable calls to `atom` (and friends) we replace the `CallExpr` right then and there. This makes it so that we don't need to deal with `export` handling, or accidentally replace entire expressions with erroneous cached atoms (See e.g. the failing test in pmndrs#36). This also solves other open issues, like pmndrs#26, pmndrs#34, and pmndrs#35. Fixes pmndrs#26 Fixes pmndrs#34 Fixes pmndrs#35
|
This is cool @martinhath. I have merged the previous PR. Could you rebase this PR and cleanup the comments, etc.? I'll take a look then. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned into an all-in-one commit:
visit_mut_*functions from VisitMut.The largest change is the fact that we perform most of the work directly
in the visitor functions. For applicable calls to
atom(and friends)we replace the
CallExprright then and there. This makes it so thatwe don't need to deal with
exporthandling, or accidentally replaceentire expressions with erroneous cached atoms (See e.g. the failing
test in #36). This also solves other open issues, like #26 , #34 , and #35 .
Fixes #26
Fixes #34
Fixes #35
I built this on top of #37, but I suppose technically speaking that's not necessary. This is a pretty large change, so if you think this is a direction to pursue it might make sense to rethink that change in the context of this anyways.
There's still some cleanup I can do, and probably a bunch of edge cases I've missed. I intend to look at these next.