Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useLoader): dispose loaders #2984

Merged
merged 4 commits into from
Sep 3, 2023
Merged

fix(useLoader): dispose loaders #2984

merged 4 commits into from
Sep 3, 2023

Conversation

CodyJasonBennett
Copy link
Member

Fixes #2812.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 1, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c388024:

Sandbox Source
example Configuration

@CodyJasonBennett CodyJasonBennett changed the title fix(useLoader): memoize loaders, dispose fix(useLoader): dispose loaders Sep 3, 2023
@CodyJasonBennett CodyJasonBennett merged commit ff3c86b into master Sep 3, 2023
1 check passed
@CodyJasonBennett CodyJasonBennett deleted the fix/useLoader-memoize branch September 3, 2023 23:36
renovate bot referenced this pull request in ziyadedher/ziyadedher Oct 4, 2023
@renovate
Update dependency @react-three/fiber to v8.14.4 (#1177)
6d0a3a3 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) |
[`8.13.0` ->
`8.14.4`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.13.0/8.14.4)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@react-three%2ffiber/8.14.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-three%2ffiber/8.14.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-three%2ffiber/8.13.0/8.14.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-three%2ffiber/8.13.0/8.14.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/react-three-fiber (@&#8203;react-three/fiber)</summary>

###
[`v8.14.4`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.14.4)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.14.3...v8.14.4)

#### What's Changed

- fix(native): amend BlobManager over globals by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/3030](https://togithub.com/pmndrs/react-three-fiber/pull/3030)

#### New Contributors

- [@&#8203;lin-stephanie](https://togithub.com/lin-stephanie) made their
first contribution in
[https://github.com/pmndrs/react-three-fiber/pull/3024](https://togithub.com/pmndrs/react-three-fiber/pull/3024)

**Full Changelog**:
pmndrs/react-three-fiber@v8.14.3...v8.14.4

###
[`v8.14.3`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.14.3)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.14.2...v8.14.3)

#### What's Changed

- fix(native): drop fsstat for react-native-web by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/3023](https://togithub.com/pmndrs/react-three-fiber/pull/3023)

**Full Changelog**:
pmndrs/react-three-fiber@v8.14.2...v8.14.3

###
[`v8.14.2`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.14.2)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.14.1...v8.14.2)

#### What's Changed

- perf(native): don't double encode assets by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2996](https://togithub.com/pmndrs/react-three-fiber/pull/2996)
- fix(useLoader): loosen Loader onError signature by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/3011](https://togithub.com/pmndrs/react-three-fiber/pull/3011)

**Full Changelog**:
pmndrs/react-three-fiber@v8.14.1...v8.14.2

###
[`v8.14.1`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.14.1)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.14.0...v8.14.1)

#### What's Changed

- fix(native): prefer local uri for fs by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2993](https://togithub.com/pmndrs/react-three-fiber/pull/2993)

**Full Changelog**:
pmndrs/react-three-fiber@v8.14.0...v8.14.1

###
[`v8.14.0`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.14.0):
8.14.0

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.9...v8.14.0)

##### What's Changed

- experiment(native): implement missing Blob/URL/fetch APIs by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2982](https://togithub.com/pmndrs/react-three-fiber/pull/2982)
- feat(native): use PanResponder for react-native-web by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2985](https://togithub.com/pmndrs/react-three-fiber/pull/2985)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.9...v8.14.0

###
[`v8.13.9`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.9)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.8...v8.13.9)

#### What's Changed

- fix(native): TextureLoader should remain consistent with FileLoader by
[@&#8203;l3utterfly](https://togithub.com/l3utterfly) in
[https://github.com/pmndrs/react-three-fiber/pull/2986](https://togithub.com/pmndrs/react-three-fiber/pull/2986)

#### New Contributors

- [@&#8203;l3utterfly](https://togithub.com/l3utterfly) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2986](https://togithub.com/pmndrs/react-three-fiber/pull/2986)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.8...v8.13.9

###
[`v8.13.8`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.8)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/8.13.7...v8.13.8)

#### What's Changed

- fix(useLoader): dispose loaders by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2984](https://togithub.com/pmndrs/react-three-fiber/pull/2984)

#### New Contributors

- [@&#8203;GmBodhi](https://togithub.com/GmBodhi) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2976](https://togithub.com/pmndrs/react-three-fiber/pull/2976)

**Full Changelog**:
pmndrs/react-three-fiber@8.13.7...v8.13.8

###
[`v8.13.7`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/8.13.7)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.6...8.13.7)

#### What's Changed

- fix(Canvas): pass scene prop by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2975](https://togithub.com/pmndrs/react-three-fiber/pull/2975)

#### New Contributors

- [@&#8203;GabeDahl](https://togithub.com/GabeDahl) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2968](https://togithub.com/pmndrs/react-three-fiber/pull/2968)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.6...8.13.7

###
[`v8.13.6`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.6)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.5...v8.13.6)

#### What's Changed

- fix: harden XR init against Renderer shim by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2947](https://togithub.com/pmndrs/react-three-fiber/pull/2947)

#### New Contributors

- [@&#8203;hood](https://togithub.com/hood) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2898](https://togithub.com/pmndrs/react-three-fiber/pull/2898)
- [@&#8203;Sargsian](https://togithub.com/Sargsian) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2922](https://togithub.com/pmndrs/react-three-fiber/pull/2922)
- [@&#8203;myznikovgleb](https://togithub.com/myznikovgleb) made their
first contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2935](https://togithub.com/pmndrs/react-three-fiber/pull/2935)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.5...v8.13.6

###
[`v8.13.5`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.5)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.4...v8.13.5)

#### What's Changed

- fix(types): remove reference to
[@&#8203;types/webxr](https://togithub.com/types/webxr) by
[@&#8203;Methuselah96](https://togithub.com/Methuselah96) in
[https://github.com/pmndrs/react-three-fiber/pull/2919](https://togithub.com/pmndrs/react-three-fiber/pull/2919)
- fix(types): harden colors overload since r153 by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2931](https://togithub.com/pmndrs/react-three-fiber/pull/2931)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.4...v8.13.5

###
[`v8.13.4`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.4)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/@react-three/[email protected])

##### What's Changed

- fix: safely diff instances by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2906](https://togithub.com/pmndrs/react-three-fiber/pull/2906)

##### New Contributors

- [@&#8203;bhouston](https://togithub.com/bhouston) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2896](https://togithub.com/pmndrs/react-three-fiber/pull/2896)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.2...v8.13.4

###
[`v8.13.3`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.3)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/@react-three/[email protected]...@react-three/[email protected])

#### What's Changed

- fix: revert nestable portals, up suspend-react by
[@&#8203;drcmda](https://togithub.com/drcmda) in
[`05187c2`](https://togithub.com/pmndrs/react-three-fiber/commit/05187c22fcac8d480120ffe1133ebe85049cb552)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.2...v8.13.3

###
[`v8.13.2`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.2)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.1...@react-three/[email protected])

#### What's Changed

- fix: update suspend-react by
[@&#8203;drcmda](https://togithub.com/drcmda) in
[`95e71ae`](https://togithub.com/pmndrs/react-three-fiber/commit/95e71ae00e8ede868b9584891e8e9b04d54d0f4e)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.1...v8.13.2

###
[`v8.13.1`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.1)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.0...v8.13.1)

#### What's Changed

- docs: update links to legacy react docs by
[@&#8203;ninofiliu](https://togithub.com/ninofiliu) in
[https://github.com/pmndrs/react-three-fiber/pull/2858](https://togithub.com/pmndrs/react-three-fiber/pull/2858)
- fix(core): unlink primitives on dispose by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2877](https://togithub.com/pmndrs/react-three-fiber/pull/2877)
- fix(core): portals should be nestable by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2746](https://togithub.com/pmndrs/react-three-fiber/pull/2746)

#### New Contributors

- [@&#8203;ninofiliu](https://togithub.com/ninofiliu) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2858](https://togithub.com/pmndrs/react-three-fiber/pull/2858)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.0...v8.13.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ziyadedher referenced this pull request in ziyadedher/ziyadedher Dec 16, 2023
@renovate
Update dependency @react-three/fiber to v8.14.4 (#1177)
4f99682 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) |
[`8.13.0` ->
`8.14.4`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.13.0/8.14.4)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@react-three%2ffiber/8.14.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@react-three%2ffiber/8.14.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@react-three%2ffiber/8.13.0/8.14.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@react-three%2ffiber/8.13.0/8.14.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pmndrs/react-three-fiber (@&#8203;react-three/fiber)</summary>

###
[`v8.14.4`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.14.4)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.14.3...v8.14.4)

#### What's Changed

- fix(native): amend BlobManager over globals by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/3030](https://togithub.com/pmndrs/react-three-fiber/pull/3030)

#### New Contributors

- [@&#8203;lin-stephanie](https://togithub.com/lin-stephanie) made their
first contribution in
[https://github.com/pmndrs/react-three-fiber/pull/3024](https://togithub.com/pmndrs/react-three-fiber/pull/3024)

**Full Changelog**:
pmndrs/react-three-fiber@v8.14.3...v8.14.4

###
[`v8.14.3`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.14.3)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.14.2...v8.14.3)

#### What's Changed

- fix(native): drop fsstat for react-native-web by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/3023](https://togithub.com/pmndrs/react-three-fiber/pull/3023)

**Full Changelog**:
pmndrs/react-three-fiber@v8.14.2...v8.14.3

###
[`v8.14.2`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.14.2)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.14.1...v8.14.2)

#### What's Changed

- perf(native): don't double encode assets by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2996](https://togithub.com/pmndrs/react-three-fiber/pull/2996)
- fix(useLoader): loosen Loader onError signature by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/3011](https://togithub.com/pmndrs/react-three-fiber/pull/3011)

**Full Changelog**:
pmndrs/react-three-fiber@v8.14.1...v8.14.2

###
[`v8.14.1`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.14.1)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.14.0...v8.14.1)

#### What's Changed

- fix(native): prefer local uri for fs by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2993](https://togithub.com/pmndrs/react-three-fiber/pull/2993)

**Full Changelog**:
pmndrs/react-three-fiber@v8.14.0...v8.14.1

###
[`v8.14.0`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.14.0):
8.14.0

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.9...v8.14.0)

##### What's Changed

- experiment(native): implement missing Blob/URL/fetch APIs by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2982](https://togithub.com/pmndrs/react-three-fiber/pull/2982)
- feat(native): use PanResponder for react-native-web by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2985](https://togithub.com/pmndrs/react-three-fiber/pull/2985)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.9...v8.14.0

###
[`v8.13.9`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.9)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.8...v8.13.9)

#### What's Changed

- fix(native): TextureLoader should remain consistent with FileLoader by
[@&#8203;l3utterfly](https://togithub.com/l3utterfly) in
[https://github.com/pmndrs/react-three-fiber/pull/2986](https://togithub.com/pmndrs/react-three-fiber/pull/2986)

#### New Contributors

- [@&#8203;l3utterfly](https://togithub.com/l3utterfly) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2986](https://togithub.com/pmndrs/react-three-fiber/pull/2986)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.8...v8.13.9

###
[`v8.13.8`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.8)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/8.13.7...v8.13.8)

#### What's Changed

- fix(useLoader): dispose loaders by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2984](https://togithub.com/pmndrs/react-three-fiber/pull/2984)

#### New Contributors

- [@&#8203;GmBodhi](https://togithub.com/GmBodhi) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2976](https://togithub.com/pmndrs/react-three-fiber/pull/2976)

**Full Changelog**:
pmndrs/react-three-fiber@8.13.7...v8.13.8

###
[`v8.13.7`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/8.13.7)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.6...8.13.7)

#### What's Changed

- fix(Canvas): pass scene prop by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2975](https://togithub.com/pmndrs/react-three-fiber/pull/2975)

#### New Contributors

- [@&#8203;GabeDahl](https://togithub.com/GabeDahl) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2968](https://togithub.com/pmndrs/react-three-fiber/pull/2968)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.6...8.13.7

###
[`v8.13.6`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.6)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.5...v8.13.6)

#### What's Changed

- fix: harden XR init against Renderer shim by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2947](https://togithub.com/pmndrs/react-three-fiber/pull/2947)

#### New Contributors

- [@&#8203;hood](https://togithub.com/hood) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2898](https://togithub.com/pmndrs/react-three-fiber/pull/2898)
- [@&#8203;Sargsian](https://togithub.com/Sargsian) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2922](https://togithub.com/pmndrs/react-three-fiber/pull/2922)
- [@&#8203;myznikovgleb](https://togithub.com/myznikovgleb) made their
first contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2935](https://togithub.com/pmndrs/react-three-fiber/pull/2935)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.5...v8.13.6

###
[`v8.13.5`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.5)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.4...v8.13.5)

#### What's Changed

- fix(types): remove reference to
[@&#8203;types/webxr](https://togithub.com/types/webxr) by
[@&#8203;Methuselah96](https://togithub.com/Methuselah96) in
[https://github.com/pmndrs/react-three-fiber/pull/2919](https://togithub.com/pmndrs/react-three-fiber/pull/2919)
- fix(types): harden colors overload since r153 by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2931](https://togithub.com/pmndrs/react-three-fiber/pull/2931)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.4...v8.13.5

###
[`v8.13.4`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.4)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/@react-three/[email protected])

##### What's Changed

- fix: safely diff instances by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2906](https://togithub.com/pmndrs/react-three-fiber/pull/2906)

##### New Contributors

- [@&#8203;bhouston](https://togithub.com/bhouston) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2896](https://togithub.com/pmndrs/react-three-fiber/pull/2896)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.2...v8.13.4

###
[`v8.13.3`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.3)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/@react-three/[email protected]...@react-three/[email protected])

#### What's Changed

- fix: revert nestable portals, up suspend-react by
[@&#8203;drcmda](https://togithub.com/drcmda) in
[`05187c2`](https://togithub.com/pmndrs/react-three-fiber/commit/05187c22fcac8d480120ffe1133ebe85049cb552)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.2...v8.13.3

###
[`v8.13.2`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.2)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.1...@react-three/[email protected])

#### What's Changed

- fix: update suspend-react by
[@&#8203;drcmda](https://togithub.com/drcmda) in
[`95e71ae`](https://togithub.com/pmndrs/react-three-fiber/commit/95e71ae00e8ede868b9584891e8e9b04d54d0f4e)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.1...v8.13.2

###
[`v8.13.1`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.13.1)

[Compare
Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.13.0...v8.13.1)

#### What's Changed

- docs: update links to legacy react docs by
[@&#8203;ninofiliu](https://togithub.com/ninofiliu) in
[https://github.com/pmndrs/react-three-fiber/pull/2858](https://togithub.com/pmndrs/react-three-fiber/pull/2858)
- fix(core): unlink primitives on dispose by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2877](https://togithub.com/pmndrs/react-three-fiber/pull/2877)
- fix(core): portals should be nestable by
[@&#8203;CodyJasonBennett](https://togithub.com/CodyJasonBennett) in
[https://github.com/pmndrs/react-three-fiber/pull/2746](https://togithub.com/pmndrs/react-three-fiber/pull/2746)

#### New Contributors

- [@&#8203;ninofiliu](https://togithub.com/ninofiliu) made their first
contribution in
[https://github.com/pmndrs/react-three-fiber/pull/2858](https://togithub.com/pmndrs/react-three-fiber/pull/2858)

**Full Changelog**:
pmndrs/react-three-fiber@v8.13.0...v8.13.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ziyadedher/ziyadedher).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nikolaseu
nikolaseu reviewed Apr 13, 2024
View reviewed changes
packages/fiber/src/core/hooks.tsx
@@ -103,7 +110,7 @@ function loadingFn<L extends LoaderProto<any>>(
),
),
),
)
).finally(() => (loader as any).dispose?.())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @CodyJasonBennett this breaks using DRACOLoader directly (useLoader(DRACOLoader, url), without useGTLF() or similar), since DRACOLoader cannot be used again after dispose https://threejs.org/docs/#examples/en/loaders/DRACOLoader.dispose

At the moment I simply workaround this by making dispose() not do anything.

While debugging this issue I also checked #3131, and I think it won't work as expected, I think dispose() should not be called if the user wants to reuse a particular loader.

What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. This was an oversight.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in https://github.com/pmndrs/react-three-fiber/releases/tag/v8.16.2.

@CodyJasonBennett CodyJasonBennett mentioned this pull request Apr 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolaseu nikolaseu nikolaseu left review comments

@drcmda drcmda Awaiting requested review from drcmda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useLoader() does not dispose of loader instance (causes memory leak with KTX2Loader)
2 participants
@CodyJasonBennett @nikolaseu