Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HBAO + SSGI + TRAA + MotionBlur #211

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

CodyJasonBennett
Copy link
Member

@CodyJasonBennett CodyJasonBennett commented May 23, 2023

Implements #183
Implements 0beqz/realism-effects#5

Follows up #210 by adding HBAO + SSGI + TRAA + MotionBlur passes from 0beqz/realism-effects.

<EffectComposer disableNormalPass multisampling={0}>
  <HBAO /> // Note: this is a component of SSGI and thus redundant
  <SSGI />
  <TRAA />
  <MotionBlur />
</EffectComposer>

https://codesandbox.io/s/c143do

image

@CodyJasonBennett CodyJasonBennett changed the title feat: SSGI feat: SSGI + TRAA May 24, 2023
@CodyJasonBennett CodyJasonBennett changed the title feat: SSGI + TRAA feat: SSGI + TRAA + MotionBlur May 24, 2023
@CodyJasonBennett CodyJasonBennett changed the title feat: SSGI + TRAA + MotionBlur feat: HBAO + SSGI + TRAA + MotionBlur May 24, 2023
@talentlessguy
Copy link
Member

@CodyJasonBennett there's merge conflicts, also safe to merge after?

@CodyJasonBennett
Copy link
Member Author

CodyJasonBennett commented May 27, 2023

Can clear those in a moment. Need to do integration testing still, but it could be worthwhile to wait until 0beqz updates SSGI as it dramatically reduces memory usage and smearing. Need to also see if there's a diffuse-only or specular-only (SSR) GI and whether we can combine his effects at all. I get a broken render when combining all into an effectpass as per his readme.

@dswhy
Copy link

dswhy commented Jun 21, 2023

Any estimation on when this could be available? I would really love to use the motion blur :D

@kitaedesigns
Copy link

Wow I cannot wait for this merge! 🤤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants