[core] Expose collections from getters as XPath sequence attributes #4969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When Saxon determines that it needs to atomize an attribute rather than getStringValue() we were not producing deprecation warnings.
- no longer need to manually add the attributes… - …but the format is slightly different
Generated by 🚫 Danger |
|
Once this is merged, we will need to update the PMD Designer to properly handle these attribute types in the UI. |
oowekyala
reviewed
Apr 20, 2024
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/ast/InnerClassLocations.txt
Outdated
Show resolved
Hide resolved
pmd-core/src/main/java/net/sourceforge/pmd/lang/rule/xpath/internal/SaxonXPathRuleQuery.java
Show resolved
Hide resolved
adangel
reviewed
Apr 25, 2024
There was a problem hiding this comment.
I think we should address first the comments. That means, this enhancement has to wait unfortunately for 7.2.0.
But then we might be able to
- provide an updated PMD Designer which can properly handle these attribute types
- have updated documentation, maybe with examples
- have a better evaluation of the impact of this enhancement, because now by default lists are exposed which weren't before and not all might make sense.
pmd-core/src/main/java/net/sourceforge/pmd/lang/rule/xpath/impl/AttributeAxisIterator.java
Outdated
Show resolved
Hide resolved
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/ast/GitHubBug208.txt
Show resolved
Hide resolved
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/ast/InnerClassLocations.txt
Outdated
Show resolved
Hide resolved
adangel
added
the
in:xpath
Co-authored-by: Clément Fournier <[email protected]>
…ernal/SaxonXPathRuleQuery.java Co-authored-by: Clément Fournier <[email protected]>
adangel
approved these changes
May 2, 2024
Co-authored-by: Andreas Dangel <[email protected]>
Co-authored-by: Andreas Dangel <[email protected]>
|
Is there anything missing on this? I'd love to get started on the designer changes needed for this… |
oowekyala
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
In the past PMD has only exposed as attributes getters that retrieve a primitive (boxed or unboxed), a String or an enum. This change expands upon that also allowing to expose any
java.util.Collectionas a sequence, as long as the values are theselves one of those types.Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)