Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch 'click' events on widgets that were added after loading the DOM #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

witsch
Copy link
Member

@witsch witsch commented Jan 11, 2021

For (multi selection) widgets that were added after loading the DOM the 'click' event no longer worked because using on the selector needs to be on a wrapper element here (as well).

This fixes 019772d and belongs to #9.

Without this the widgets cannot be "opened" again when using jQuery 1.7, i.e. on Plone 4.x.

For (multi selection) widgets that were added after loading the DOM the
'click' event no longer worked because using `on` the selector needs to
be on a wrapper element here (as well).

This fixes 019772d and belongs to plone#9.
@mister-roboto
Copy link

@witsch thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@witsch witsch changed the title Also catch clicks on widgets that were added later Catch 'click' events on widgets that were added after loading the DOM Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants