Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt-scalajs, scalajs-compiler, ... 1.16.0 (was 1.15.0) #750

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

scala-steward
Copy link
Contributor

About this PR

📦 Updates

from 1.15.0 to 1.16.0

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-js" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-js" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@mergify mergify bot added the type:updates label Mar 22, 2024
@mkurz
Copy link
Member

mkurz commented Apr 25, 2024

I will not merge this and #753 for now, because according to https://www.scala-js.org/news/2024/03/19/announcing-scalajs-1.16.0/ there might be "Enhancements with compatibility concerns" and also "it is not guaranteed that a codebase will compile as is when upgrading from 1.15.x (in particular in the presence of -Xfatal-warnings)."

We can wait, if people want to have it upgraded, please comment here, thanks!

@mkurz
Copy link
Member

mkurz commented Apr 25, 2024

OK, we have to merge it otherwise we can not upgrade scala-xml (which we should IMHO), see error in #756:

[error] org.scalajs.ir.IRVersionNotSupportedException: Failed to deserialize a file compiled with Scala.js 1.16 (supported up to: 1.13): /home/runner/.cache/coursier/v1/https/repo1.maven.org/maven2/org/scala-js/scalajs-library_2.13/1.16.0/scalajs-library_2.13-1.16.0.jar:/scala/scalajs/LinkingInfo.sjsir
[error] You may need to upgrade the Scala.js sbt plugin to version 1.16 or later.

@mkurz
Copy link
Member

mkurz commented Apr 25, 2024

Hmm... ok, not, I will not merge any of these right now, scala-xml also upgrades scala-native to 0.5.0: https://scala-native.org/en/latest/changelog/0.5.x/0.5.0.html
I just don't want to break anything in a patch release if not absolutely necessary so I will not merge it right now.

@mkurz
Copy link
Member

mkurz commented Jun 27, 2024

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Jun 27, 2024

rebase

✅ Branch has been successfully rebased

@mkurz mkurz force-pushed the update/sbt-scalajs-1.16.0 branch from 4444eb0 to 26b26ff Compare June 27, 2024 16:40
@mkurz mkurz marked this pull request as ready for review June 27, 2024 16:59
@mkurz mkurz merged commit 247e9f5 into playframework:main Jun 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants