Add instruction for running evolutions with Slick using compile-time DI #402
Conversation
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
======================================
Coverage 7.71% 7.71%
======================================
Files 19 19
Lines 842 842
Branches 9 8 -1
======================================
Hits 65 65
Misses 777 777Continue to review full report at Codecov.
|
| @@ -41,6 +41,9 @@ Note there is no need to add the Play `evolutions` component to your dependencie | |||
|
|
|||
| > **Note**: You can see th | |||
|
|
|||
| #### Running evolutions with Slick using compile-time DI | |||
| If you are using Slick, you will also need to mix in the `SlickEvolutionsComponents` trait in addition to the `EvolutionsComponents` trait to `ApplicationComponents`. Else evolutions will not recognize the Slick database configurations in the configuration files. | |||
|
|
|||
There was a problem hiding this comment.
It could be good to add a code sample here. You can see the recommended way of adding code samples here:
https://playframework.com/documentation/2.5.x/Documentation#Code-samples
There was a problem hiding this comment.
Actually, what do you think about changing the name to SlickDBComponents instead of SlickEvolutionsComponents? That would make things more straightforward since this basically replaces DBComponents. Then we can deprecate the whole trait instead of just that api method.
There was a problem hiding this comment.
Thank you, @annikasirapandji.
Just a small comment to add a code sample, but besides that, this looks good to me.
|
Hi @annikasirapandji, could you please rebase against master branch? Also, if you still have time, could you take a look at the comments made above? If not, please let me know and I can do it later. :-) Moreover, thanks for contributing and sorry for the huge delay to move this forward. |
dwijnand
added
status:ready
status:backlog
and removed
status:backlog
status:ready
labels
|
How can I help to get this really helpful pull request merged? Should I add a code snippet? |
No description provided.