Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace skybox shader generator with a ShaderMaterial using few defines #7301

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Replace skybox shader generator with a ShaderMaterial using few defines #7301

merged 1 commit into from
Jan 20, 2025

Conversation

mvaligursky
Copy link
Contributor

  • equivalent functionality, leaning on ShaderMaterial to handle most of it.

@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Jan 20, 2025
@mvaligursky mvaligursky self-assigned this Jan 20, 2025
@mvaligursky mvaligursky marked this pull request as draft January 20, 2025 15:38
@mvaligursky mvaligursky marked this pull request as ready for review January 20, 2025 15:38
@mvaligursky mvaligursky merged commit 0e58330 into main Jan 20, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-remove-skybox-shadergen branch January 20, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck