Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid Script fixes #7295

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Grid Script fixes #7295

wants to merge 6 commits into from

Conversation

marklundin
Copy link
Member

@marklundin marklundin commented Jan 17, 2025 •
edited
Loading

The Grid Script fixes a rendering issues with the shadow catcher. It also simplifies the shader by refactoring to use internal uniforms

  • Ensures Grid does not cast shadows
  • Removes halfExtents uniform
  • Use internal camera uniforms

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@marklundin marklundin self-assigned this Jan 17, 2025
@mvaligursky mvaligursky requested a review from slimbuck January 17, 2025 19:04
kpal81xd
kpal81xd requested changes Jan 20, 2025
View reviewed changes
scripts/esm/grid.mjs Show resolved Hide resolved
@marklundin marklundin changed the title Write depth in Grid Script Grid Script fixes Jan 20, 2025
@marklundin marklundin requested a review from kpal81xd January 20, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeXXik LeXXik LeXXik left review comments

@mvaligursky mvaligursky Awaiting requested review from mvaligursky

@slimbuck slimbuck Awaiting requested review from slimbuck

@kpal81xd kpal81xd Awaiting requested review from kpal81xd

Requested changes must be addressed to merge this pull request.

Assignees

@marklundin marklundin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marklundin @LeXXik @kpal81xd