Refactor first-person controller script #7289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpal81xd
approved these changes
Jan 17, 2025
marklundin
commented
Jan 17, 2025
| @@ -942,7 +955,7 @@ class FirstPersonController extends Script { | |||
| * @range [0, 0.4] | |||
| */ | |||
| set gamePadDeadZoneLow(value) { | |||
| this._gamePadDeadZoneLow = value; | |||
| this._gamePadDeadZoneLow = value ?? this._gamePadDeadZoneLow; | |||
| if (this._gamePadInput) { | |||
| this._gamePadInput.deadZoneLow = value; | |||
There was a problem hiding this comment.
Since you're checking for nullish, should this not be this._gamePadInput.deadZoneLow = this._gamePadDeadZoneLow
mvaligursky
pushed a commit
that referenced
this pull request
Jan 17, 2025
* Refactor first-person controller script * Fixed camera init and collision and rigidibody init * Refactor input classes to handle null values for enabled property --------- Co-authored-by: KPal <[email protected]> Co-authored-by: kpal81xd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors First Person Controller script to use
initialize()instead of the constructorI confirm I have read the contributing guidelines and signed the Contributor License Agreement.